You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[bug] Operator becoming non-functional after transient RBAC changes #1419
Hi all and thanks for the amazing project!
I was looking at real-world edge cases where the functionality of the operator gets compromised because the Informers are crashing in background.
A little playing with RBAC resources with an operator running turns it to be completely unresponsive on any CR event.
doesn't react to the creation of a new CR e.g. kubectl apply -f sample-operators/tomcat-operator/k8s/tomcat-sample2.yaml
What did you expect to see?
The operator pod should(probably) restart in case it loose access to the API in order to be able to restore the communication.
Alternatively, the situation should be handled and, somehow, the connection of the SharedInformers restored.
What did you see instead? Under which circumstances?
The operator remains unresponsive but alive.
Environment
Kubernetes cluster type: minikube
$ Mention java-operator-sdk version from pom.xml file main
$ java -version
openjdk version "11.0.15" 2022-04-19
OpenJDK Runtime Environment Temurin-11.0.15+10 (build 11.0.15+10)
OpenJDK 64-Bit Server VM Temurin-11.0.15+10 (build 11.0.15+10, mixed mode)
$ kubectl version
Possible Solution
The best would be to have callback endpoint in the Controller that gets called if an error happens with the SharedInformers, so that the user can decide what to do.
At a very minimum, in this specific situation, I do believe that crashing the Operator is the correct behavior, but it would be nice to have a more generic mechanism for handling SharedInformers failures that are currently happening in background.
Additional context
During my test, I verified that the communication with the API server gets restored if the API server becomes temporarily unavailable, that's great work 👍
Activity
andreaTP commentedon Aug 24, 2022
cc. @lburgazzoli
csviri commentedon Aug 24, 2022
Probably related to this issue:
#1405
andreaTP commentedon Aug 24, 2022
Related to #1170 also.
Please note that a pod restart recovers the situation.
andreaTP commentedon Oct 27, 2022
@csviri do we have an integration test for this?
csviri commentedon Oct 27, 2022
yep: https://github.com/java-operator-sdk/java-operator-sdk/blob/2cb616c4c4fd0094ee6e3a0ef2a0ea82173372bf/operator-framework/src/test/java/io/javaoperatorsdk/operator/InformerRelatedBehaviorITS.java
@andreaTP
it is a little special, since it is not trivial to test. See javadocs on the test class.
andreaTP commentedon Oct 27, 2022
awesome! thanks!