Skip to content

[bug] Operator becoming non-functional after transient RBAC changes #1419

Closed

Description

@andreaTP

Bug Report

Hi all and thanks for the amazing project!
I was looking at real-world edge cases where the functionality of the operator gets compromised because the Informers are crashing in background.
A little playing with RBAC resources with an operator running turns it to be completely unresponsive on any CR event.

What did you do?

  • start a new minikube cluster
  • deploy the sample tomcat-operator
  • kubectl apply -f sample-operators/tomcat-operator/k8s/tomcat-sample1.yaml
  • kubectl delete serviceaccount/tomcat-operator -n tomcat-operator
  • wait for the reconciliation loop to exhaust the retries
  • re-create the Service Account:
kubectl apply -f - <<EOF
apiVersion: v1
kind: ServiceAccount
metadata:
  name: tomcat-operator
  namespace: tomcat-operator
EOF

Now the operator becomes completely unresponsive:

  • doesn't react to changes to the test-tomcat1 CR
  • doesn't react to the creation of a new CR e.g. kubectl apply -f sample-operators/tomcat-operator/k8s/tomcat-sample2.yaml

What did you expect to see?

The operator pod should(probably) restart in case it loose access to the API in order to be able to restore the communication.
Alternatively, the situation should be handled and, somehow, the connection of the SharedInformers restored.

What did you see instead? Under which circumstances?

The operator remains unresponsive but alive.

Environment

Kubernetes cluster type:
minikube

$ Mention java-operator-sdk version from pom.xml file
main

$ java -version

openjdk version "11.0.15" 2022-04-19
OpenJDK Runtime Environment Temurin-11.0.15+10 (build 11.0.15+10)
OpenJDK 64-Bit Server VM Temurin-11.0.15+10 (build 11.0.15+10, mixed mode)

$ kubectl version

Possible Solution

The best would be to have callback endpoint in the Controller that gets called if an error happens with the SharedInformers, so that the user can decide what to do.
At a very minimum, in this specific situation, I do believe that crashing the Operator is the correct behavior, but it would be nice to have a more generic mechanism for handling SharedInformers failures that are currently happening in background.

Additional context

During my test, I verified that the communication with the API server gets restored if the API server becomes temporarily unavailable, that's great work 👍

Activity

  1. andreaTP commented on Aug 24, 2022

    @andreaTP
    CollaboratorAuthor
  2. csviri commented on Aug 24, 2022

    @csviri
    Collaborator

    Probably related to this issue:
    #1405

  3. andreaTP commented on Aug 24, 2022

    @andreaTP
    CollaboratorAuthor

    Related to #1170 also.
    Please note that a pod restart recovers the situation.

  4. added this to the 3.3 milestone on Aug 25, 2022
  5. self-assigned this
    on Oct 4, 2022
  6. andreaTP commented on Oct 27, 2022

    @andreaTP
    CollaboratorAuthor

    @csviri do we have an integration test for this?

  7. csviri commented on Oct 27, 2022

    @csviri
    Collaborator
  8. andreaTP commented on Oct 27, 2022

    @andreaTP
    CollaboratorAuthor

    awesome! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions