Skip to content

Support for K8S Probes #1412

Closed
Closed

Description

@csviri

This issue is about supporting Kubernetes Probes from the framework.

The main question is how to map probes to operators in general:

  • Liveness - is operator started? (So start method called?) Is there any other meaningful way?.
    Should be this bound to sync timeout: Event Source Sync Timeout #1318 ? So if out of sync it is basically not alive?

  • Readyness (or Startup?) - probes is naturally can be bidden to event source sync, so the operator is ready when event sources are already synced.

The API:

Operator operator = new Operator()
...
operator.start()

// from this point the methods
boolean ready = operator.isReady()
boolean alive = operator.isAlive()

User later can call those methods from a servlet container or whatever integration chooses with K8S for the probes.

Activity

  1. added this to the 3.3 milestone on Aug 22, 2022
  2. changed the title [-]Support for Probes[/-] [+]Support for K8S Probes[/+] on Aug 22, 2022
  3. csviri commented on Aug 25, 2022

    @csviri
    CollaboratorAuthor

    An other thing we should check in the probes if the informers are watching:
    fabric8io/kubernetes-client#4340 (comment)

    So probably the operator is not ready if the informers are not watching.

    But this is related also with the issue: #1405
    Where we want to start informers, and if there is not permission for the informer (and not watching) that is fine.
    This however this probably requires explicit checking of permission.

  4. modified the milestones: 4.1, 4.2 on Oct 19, 2022
  5. self-assigned this
    on Oct 31, 2022
  6. linked a pull request that will close this issuefeat: runtime info for health probes #1594on Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions