Skip to content

Define Event Sources Using @ControllerConfiguration Annotation #1298

Closed

Description

@csviri

It would be elegant to define event sources using annotations (just as we define dependent resources).

Proposed design for annotation would look like this:

@ControllerConfiguration(
    eventSources = @EventSources(informers = @Informer(resourceType = ConfigMap.class,
        followNamespaceChanges = true),others = @EventSource(type = MyPollingEventSource.class)))
public class SampleReconciler

where @Informer annotation would have most of the configurations, that could be defined by the config builder:
see: https://github.com/java-operator-sdk/java-operator-sdk/blob/6fd141fe1c3922fed11995814a222bcce446b015/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Informer.java

Notes:

  • these event sources won't be subject of configuration override.

Activity

  1. self-assigned this
    on Jun 22, 2022
  2. added this to the 3.1 milestone on Jun 22, 2022
  3. linked a pull request that will close this issuefeat: define event sources with annotations #1306on Jun 29, 2022
  4. modified the milestones: 3.1, 3.2 on Jul 13, 2022
  5. removed this from the 3.2 milestone on Aug 26, 2022
  6. csviri commented on Apr 26, 2024

    @csviri
    CollaboratorAuthor

    We agreed that this won't be supported for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions