Repository navigation
DependentResource and Workflow Design Details Questions #1263
Description
This issue is a summary some design questions related to dependent resources and workflows.
-
Currently if a dependent resource is ready (ReadyCondition) in workflows (so is in a target state) or if is delete process successfully finished (DeletePostCondition) - this can be async - is handled by Conditions. However it might be more convenient especially using it from standalone mode to put this information toReconcileResultand also provideDeleteResultwhere the result of those predicates could be added. Also might be a better / more efficient place to check it in the reconcile. - Should we make in all condition names explicit if it is a post or precondition. Ready is a post, Reconcile is a pre-condition. The delete condition already has post in its name. See original design:
Depends On and Conditions to describe workflows Dependent Resources #850 (only applies to reconcile condition if we decide to change the point above)
Activity
[-]Some DependentResource and Workflow Design Details[/-][+]DependentResource and Workflow Design Details Questions[/+]csviri commentedon Jun 6, 2022
Made the condition names more explicit (pre and post condition) in the following PR:
#1257
csviri commentedon Jun 6, 2022
After giving more thoughts and implementing samples (Integration tests). Having the postconditions explicit makes more sense. It is good for reusability, also for decoupling the condition related logic. For now I would say we could keep it separated and maybe change if we have some related feedback.
csviri commentedon Jun 6, 2022
Will close this issue for now, and reopen in case.