Skip to content

[release-4.16] OCPBUGS-103062, OCPBUGS-103064: Go HTTP/2: Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame - #806

Open
UdayYendva wants to merge 1 commit into
openshift:release-4.16from
UdayYendva:release-4.16
Open

UdayYendva wants to merge 1 commit into
openshift:release-4.16from
UdayYendva:release-4.16

Conversation

@UdayYendva

Copy link
Copy Markdown

Bump golang.org/x/net to address CVE-2026-33814 vulnerability using fork patch inorder to avoid the go version bump.

…sion to solve CVE-2026-33814 vulnerability force added vendor
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 4d0b1ad9-529d-4aae-92f2-254a39fcfe65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@UdayYendva: This pull request references Jira Issue OCPBUGS-103064, which is invalid:

  • expected dependent Jira Issue OCPBUGS-103269 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump golang.org/x/net to address CVE-2026-33814 vulnerability using fork patch inorder to avoid the go version bump.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: UdayYendva
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@UdayYendva

Copy link
Copy Markdown
Author

/retest-required

@UdayYendva

Copy link
Copy Markdown
Author

/test unit

@UdayYendva

Copy link
Copy Markdown
Author

/retest-required

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

The ci/prow/unit job failure is NOT caused by this PR's changes. This is a known CI infrastructure issue affecting all PRs on release-4.14, release-4.15, and release-4.16 branches.

Root Cause:
The Go 1.21 CI container image used by these older release branches is missing the gotest2junit binary. The unit test Makefile (test-unit.mk) requires this tool to generate JUnit XML reports, and aborts immediately when it's not found:

test-unit.mk:10: *** gotest2junit not found

No Go tests ever execute — the failure happens during make setup, before test compilation even starts.

Evidence:

  • This PR only bumps vendored golang.org/x/net for CVE-2026-33814 — no test code or Makefile changes
  • The unit job has a 0% pass rate on release-4.14, 4.15, and 4.16 for the last 30+ days (all PRs fail, not just this one)
  • Newer branches (main, release-4.17, release-4.22) pass at 92–100% — confirming the issue is CI-image-specific

Request:
Could a maintainer please /override the ci/prow/unit check so this CVE fix can merge? The CI image issue should be tracked separately with the Test Platform team.


AI-generated. Review for accuracy.

@perdasilva

Copy link
Copy Markdown
Contributor

/test unit

@sunku5494

Copy link
Copy Markdown

/retitle [release-4.16] OCPBUGS-103062, OCPBUGS-103064: Go HTTP/2: Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame

@openshift-ci openshift-ci Bot changed the title OCPBUGS-103064: [release-4.16] Go HTTP/2: Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame [release-4.16] OCPBUGS-103062, OCPBUGS-103064: Go HTTP/2: Denial of Service via malformed SETTINGS_MAX_FRAME_SIZE frame Sep 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@UdayYendva: This pull request references Jira Issue OCPBUGS-103062, which is invalid:

  • expected dependent Jira Issue OCPBUGS-103266 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-103064, which is invalid:

  • expected dependent Jira Issue OCPBUGS-103269 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump golang.org/x/net to address CVE-2026-33814 vulnerability using fork patch inorder to avoid the go version bump.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

/jira refresh

1 similar comment
@openshift-merge-robot

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-merge-robot: This pull request references Jira Issue OCPBUGS-103062, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-103266 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-103266 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

This pull request references Jira Issue OCPBUGS-103064, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-103269 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-103269 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-merge-robot: This pull request references Jira Issue OCPBUGS-103062, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-103266 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-103266 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

This pull request references Jira Issue OCPBUGS-103064, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-103269 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-103269 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alexissolanas

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test openshift-e2e-aws-techpreview

@k37y

k37y commented Oct 6, 2026

Copy link
Copy Markdown

/test unit

@sunku5494

Copy link
Copy Markdown

/test unit

@germanparente

Copy link
Copy Markdown

/label backport-risk-assessed
/verified by CI
/label approved

1 similar comment
@germanparente

Copy link
Copy Markdown

/label backport-risk-assessed
/verified by CI
/label approved

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@germanparente: This PR has been marked as verified by CI.

Details

In response to this:

/label backport-risk-assessed
/verified by CI
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

Copy link
Copy Markdown

@germanparente: This PR has been marked as verified by CI.

Details

In response to this:

/label backport-risk-assessed
/verified by CI
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 12, 2026
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 80b8649 and 2 for PR HEAD 4c6fad2 in total

@UdayYendva

Copy link
Copy Markdown
Author

/retest

@bandrade

Copy link
Copy Markdown
Contributor

/override ci/prow/unit

@openshift-ci

openshift-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@bandrade: bandrade unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-ci-job-overriders openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kevinrizza

Copy link
Copy Markdown
Member

The failing job isn't an e2e flake, the unit tests job is failing and none of the tests are running. I think we need to hold this pr until the failure is investigated and resolved.

@joelanford

Copy link
Copy Markdown
Member

/hold

We cannot override failing unit tests. Something is broken here and needs to be fixed. If this merges with the tests failing, all future backports will also have failing unit tests.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2026
@joelanford

Copy link
Copy Markdown
Member

Root Cause:
The Go 1.21 CI container image used by these older release branches is missing the gotest2junit binary. The unit test Makefile (test-unit.mk) requires this tool to generate JUnit XML reports, and aborts immediately when it's not found:

test-unit.mk:10: *** gotest2junit not found
No Go tests ever execute — the failure happens during make setup, before test compilation even starts.

Is there a tracker for this somewhere?

@sunku5494

Copy link
Copy Markdown

Root Cause:
The Go 1.21 CI container image used by these older release branches is missing the gotest2junit binary. The unit test Makefile (test-unit.mk) requires this tool to generate JUnit XML reports, and aborts immediately when it's not found:
test-unit.mk:10: *** gotest2junit not found
No Go tests ever execute — the failure happens during make setup, before test compilation even starts.

Is there a tracker for this somewhere?

I have created a tracker for unit test failure and looking in to the issue. Thanks
https://redhat.atlassian.net/browse/OCPBUGS-131845

@tmshort

tmshort commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

As far as I can tell #834 fixes the unit test issue on release-4.16?

@sunku5494

Copy link
Copy Markdown

As far as I can tell #834 fixes the unit test issue on release-4.16?

Yes, #834 fixes the unit test issue in this PR. we will rebase this PR once it merges. Thanks

@ocp-sustaining-admins

Copy link
Copy Markdown

/retest-required

@openshift-ci

openshift-ci Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

@UdayYendva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 4c6fad2 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.