Repository navigation
Conversation
Feature gate reached GA in 5.0, removing from openshift/api. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
openshift-ci-robot
added
jira/valid-reference
|
@dfajmon: This pull request references Jira Issue OCPBUGS-104847, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description check |  |
The description states that the feature gate reached GA and is being removed. This directly relates to the changeset. |
| Title check | |
The title clearly identifies the issue and the primary change: removal of the SELinuxMountGAReadiness feature gate. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | |
PASS: The reviewed range changes only feature-gate documentation, Go registration, and YAML manifests. It adds no test files, Ginkgo test declarations, test titles, dynamic values, or legacy naming to… |
| Test Structure And Quality | |
PASS. The pull request changes only feature-gate documentation, Go registration data, and YAML manifests. It adds no Ginkgo tests or test blocks, so the listed test-structure requirements do not apply… |
| Microshift Test Compatibility | |
The pull request adds no Ginkgo e2e tests. The authoritative diff contains only feature-gate registry, documentation, and manifest removals, so the MicroShift test compatibility check is not applicabl… |
| Single Node Openshift (Sno) Test Compatibility | |
The pull request adds no Ginkgo or other e2e tests. The authoritative diff contains only deletions from feature-gate documentation, registration, and manifests, so it introduces no SNO multi-node comp… |
| Topology-Aware Scheduling Compatibility | |
The pull request changes only feature-gate documentation, registry code, and feature-gate payload manifests. The diff removes SELinuxMountGAReadiness entries and its registration. It adds no deploym… |
| Ote Binary Stdout Contract | |
PASS. The pull request changes only feature-gate metadata and removes the SELinuxMountGAReadiness registration and manifest entries. The diff adds no code and contains no stdout, logging, main, su… |
| Ipv6 And Disconnected Network Test Compatibility | |
The pull request only removes the SELinuxMountGAReadiness registration, documentation row, and manifest entries. The authoritative diff adds no Ginkgo tests or other test code, so this IPv4 and discon… |
| No-Weak-Crypto | |
The pull request only removes the SELinuxMountGAReadiness registration, documentation row, and manifest entries. The diff contains 44 deletions and no additions. It introduces no weak cryptography, cu… |
| Container-Privileges | |
The pull request only removes the SELinuxMountGAReadiness feature-gate entry and registration. The diff adds no lines. No changed file contains privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, al… |
| No-Sensitive-Data-In-Logs | |
The pull request only removes a feature-gate declaration, documentation row, and manifest entries. The diff adds no logging, credentials, identifiers, hostnames, or customer data. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Full details: Stable And Deterministic Test Names
-
Explanation
PASS: The reviewed range changes only feature-gate documentation, Go registration, and YAML manifests. It adds no test files, Ginkgo test declarations, test titles, dynamic values, or legacy naming tokens.
Full details: Test Structure And Quality
-
Explanation
PASS. The pull request changes only feature-gate documentation, Go registration data, and YAML manifests. It adds no Ginkgo tests or test blocks, so the listed test-structure requirements do not apply.
Full details: Microshift Test Compatibility
-
Explanation
The pull request adds no Ginkgo e2e tests. The authoritative diff contains only feature-gate registry, documentation, and manifest removals, so the MicroShift test compatibility check is not applicable.
Full details: Single Node Openshift (Sno) Test Compatibility
-
Explanation
The pull request adds no Ginkgo or other e2e tests. The authoritative diff contains only deletions from feature-gate documentation, registration, and manifests, so it introduces no SNO multi-node compatibility issue.
Full details: Topology-Aware Scheduling Compatibility
-
Explanation
The pull request changes only feature-gate documentation, registry code, and feature-gate payload manifests. The diff removes
SELinuxMountGAReadinessentries and its registration. It adds no deployments, operators, controllers, or scheduling constraints such as affinity, topology spread, replica settings, selectors, tolerations, or PDBs.
Full details: Ote Binary Stdout Contract
-
Explanation
PASS. The pull request changes only feature-gate metadata and removes the
SELinuxMountGAReadinessregistration and manifest entries. The diff adds no code and contains no stdout, logging,main, suite setup, or other OTE process-level writes.
Full details: Ipv6 And Disconnected Network Test Compatibility
-
Explanation
The pull request only removes the SELinuxMountGAReadiness registration, documentation row, and manifest entries. The authoritative diff adds no Ginkgo tests or other test code, so this IPv4 and disconnected-network test compatibility check does not apply.
Full details: No-Weak-Crypto
-
Explanation
The pull request only removes the SELinuxMountGAReadiness registration, documentation row, and manifest entries. The diff contains 44 deletions and no additions. It introduces no weak cryptography, custom crypto, or secret comparisons.
Full details: Container-Privileges
-
Explanation
The pull request only removes the SELinuxMountGAReadiness feature-gate entry and registration. The diff adds no lines. No changed file contains privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or securityContext settings.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
Comment @coderabbitai help to get the list of available commands.
|
Hello @dfajmon! Some important instructions when contributing to openshift/api: |
openshift-ci
Bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test integration |
|
@dfajmon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pipeline required |
|
The controller does not dispatch second-stage tests in agentic mode. Use |
|
/payload nightly blocking |
|
@JoelSpeed: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload 5.1 nightly blocking |
|
@JoelSpeed: trigger 14 job(s) of type blocking for the nightly release of OCP 5.1
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/02146710-ceb5-11f1-9954-e98c78435207-0 |
|
just to observe sth |
|
/pipeline skip-agentic-mode |
|
Traditional pipeline scheduling is enabled for this PR and future pushes. Running tests are unchanged. |
|
/pipeline agentic-mode |
|
Agentic mode is restored. First-stage success will create a fresh pending pipeline gate once the configured trigger is satisfied (LGTM or |
|
I think there is a gap shown here. Pipeline controller was down when 1st stage succeded. Now, there is no way to even manually trigger agentic second stage. |
|
ah, but this is lgtm mode, and there is not lgtm trigger yet |
|
@jmguzik Would |
Feature gate reached GA in 5.0, removing from openshift/api.