[redhat-chai-bot]

Summary

• Remove ImageStreamImportMode feature-gate registration, legacy entries, API field gate markers, and test gate requirements.
• Preserve permanent API fields, validation, documentation, supported values, and test cases.
• Regenerate affected feature-gate, CRD, OpenAPI, and payload artifacts.

Dependencies

Merge after cluster-image-registry-operator#1384 and cluster-version-operator#1469.

Validation

• Full make update with no post-commit diff
• Config API tests and feature-promotion verification
• make clean build, make test-unit, and make verify
• make integration: 7,096 specs passed; no failed, pending, or skipped specs
• All 29 affected API test cases retained
• git diff --check

Pre-commit review found no issues.

---

AI-generated. Review for accuracy.

@Prashanth684 requested from Slack

[openshift-merge-bot]

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs, /pipeline remaining to request missing second-stage tests, or /pipeline required to rerun the selected second-stage set.

[openshift-ci]

Hello @redhat-chai-bot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-105406, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Remove ImageStreamImportMode feature-gate registration, legacy entries, API field gate markers, and test gate requirements.
• Preserve permanent API fields, validation, documentation, supported values, and test cases.
• Regenerate affected feature-gate, CRD, OpenAPI, and payload artifacts.

Dependencies

Merge after cluster-image-registry-operator#1384 and cluster-version-operator#1469.

Validation

• Full make update with no post-commit diff
• Config API tests and feature-promotion verification
• make clean build, make test-unit, and make verify
• make integration: 7,096 specs passed; no failed, pending, or skipped specs
• All 29 affected API test cases retained
• git diff --check

Pre-commit review found no issues.

---

AI-generated. Review for accuracy.

@Prashanth684 requested from Slack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 88ac061b-15ca-4bf0-bffa-8cc36d5aeb31

📥 Commits

Reviewing files that changed from the base of the PR and between ef6066a and e3cb6d9.

⛔ Files ignored due to path filters (11)

• config/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !**/zz_generated*
• config/v1/zz_generated.featuregated-crd-manifests/clusterversions.config.openshift.io/AAA_ungated.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/clusterversions.config.openshift.io/CRDCompatibilityRequirementOperator+ClusterAPIMachineManagement.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/clusterversions.config.openshift.io/CRDCompatibilityRequirementOperator.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/clusterversions.config.openshift.io/ClusterAPIMachineManagement.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/clusterversions.config.openshift.io/ClusterUpdateAcceptRisks.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/clusterversions.config.openshift.io/ClusterUpdatePreflight.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/clusterversions.config.openshift.io/ImageStreamImportMode.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/clusterversions.config.openshift.io/SignatureStores.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/images.config.openshift.io/AAA_ungated.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
• config/v1/zz_generated.featuregated-crd-manifests/images.config.openshift.io/ImageStreamImportMode.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**

📒 Files selected for processing (22)

• config/v1/tests/clusterversions.config.openshift.io/ImageStreamImportMode.yaml
• config/v1/tests/images.config.openshift.io/ImageStreamImportMode.yaml
• config/v1/types_cluster_version.go
• config/v1/types_image.go
• features.md
• features/features.go
• features/legacyfeaturegates.go
• image/v1/tests/ImageStreamImportMode.yaml
• openshiftcontrolplane/v1/types.go
• payload-command/render/legacyfeaturegates.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (22)

• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-Default.yaml
• payload-command/render/legacyfeaturegates.go
• config/v1/tests/clusterversions.config.openshift.io/ImageStreamImportMode.yaml
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• openshiftcontrolplane/v1/types.go
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• features/legacyfeaturegates.go
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-TechPreviewNoUpgrade.yaml
• config/v1/types_image.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• image/v1/tests/ImageStreamImportMode.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• features.md
• config/v1/tests/images.config.openshift.io/ImageStreamImportMode.yaml
• features/features.go
• config/v1/types_cluster_version.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes the ImageStreamImportMode feature-gate registration and its entries from feature defaults, legacy gate sets, and payload manifests. It also removes feature-gate annotations from API fields and removes gate declarations from test configurations. The API fields and test cases remain.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to e3cb6

This change removes a feature gate that was already enabled everywhere and keeps the API fields and tests. No actionable merge-blocking risk was found. Make sure the listed dependent PRs land in the right order.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the main change: removing the ImageStreamImportMode feature gate.
Description check	✅ Passed	The description directly explains the removal of ImageStreamImportMode feature-gate registration and related markers while preserving API fields, tests, and validation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only feature-gate metadata and removes generated artifacts. The three affected test YAML files retain static test names such as `Should be able to configure imageStreamImportM…
Test Structure And Quality	✅ Passed	PASS: The pull request changes no Ginkgo test code or *_test.go files. The three affected declarative test files only remove the ImageStreamImportMode gate declaration; their test cases remain unchang…
Microshift Test Compatibility	✅ Passed	PASS: The pull request adds no new Ginkgo e2e tests. The authoritative diff contains only feature-gate, API metadata, test-configuration, and generated-manifest changes, with no added It(), Describe()…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request adds no new Ginkgo e2e tests. The authoritative diff contains only feature-gate, API, generated manifest, payload, and existing YAML test changes. No added It(), Describe(), `Cont…
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request does not add or modify deployments, operators, controllers, replica settings, affinity, topology spread, node selectors, tolerations, or PDBs. The authoritative diff only removes the …
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes feature-gate registrations, API annotations, YAML test metadata, generated manifests, payload manifests, and documentation. It does not change OTE process-level code or …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The reviewed diff adds no Ginkgo tests or test declarations. The affected test files only remove feature-gate metadata; no IPv4 literals, IPv4-only parsing, external URLs, or public connectivity…
No-Weak-Crypto	✅ Passed	The pull request does not introduce weak cryptography or custom cryptographic code. The diff removes feature-gate entries and annotations, plus regenerates API schema fields. Added content contains on…
Container-Privileges	✅ Passed	The pull request changes feature-gate registrations, API annotations, tests, generated CRDs, and feature-gate lists. The reviewed diff adds no container or Kubernetes privilege settings and contains n…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request introduces no logging. The authoritative diff contains only feature-gate removals and generated CRD schema additions for architecture; no added lines contain logger calls, credentia…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[JoelSpeed]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial-techpreview-1of2	e3cb6d9	link	true	/test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-aws-serial-1of2	e3cb6d9	link	true	/test e2e-aws-serial-1of2
ci/prow/e2e-aws-ovn	e3cb6d9	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview	e3cb6d9	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-upgrade-out-of-change	e3cb6d9	link	true	/test e2e-upgrade-out-of-change
ci/prow/e2e-upgrade	e3cb6d9	link	true	/test e2e-upgrade
ci/prow/e2e-aws-ovn-hypershift	e3cb6d9	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-2of2	e3cb6d9	link	true	/test e2e-aws-serial-2of2
ci/prow/e2e-aws-serial-techpreview-2of2	e3cb6d9	link	true	/test e2e-aws-serial-techpreview-2of2
ci/prow/minor-e2e-upgrade-minor	e3cb6d9	link	true	/test minor-e2e-upgrade-minor
ci/prow/e2e-gcp	e3cb6d9	link	true	/test e2e-gcp
ci/prow/e2e-azure	e3cb6d9	link	true	/test e2e-azure
ci/prow/e2e-aws-ovn-hypershift-conformance	e3cb6d9	link	true	/test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Prashanth684]

/hold
tests will fail until openshift/cluster-image-registry-operator#1384 is merged