Skip to content

Lock down Docker containers used for local tooling - #301

Merged
alarthast merged 3 commits into
mainfrom
alarthast/lock-down-docker
Nov 12, 2026
Merged

alarthast merged 3 commits into
mainfrom
alarthast/lock-down-docker

Conversation

@alarthast

Copy link
Copy Markdown
Contributor

Closes https://github.com/opensafely-core/security/issues/106.

  • Remove the lint-actions recipe from the repoupdater justfile and add one to the otel-gateway justfile instead, since the github actions are otel-gateway related.
  • Update the lint-docker recipe in otel-gateway to the latest repo-template.

We don't need this recipe for repoupdater - none of the workflows
involve it. We can add the recipe to the otel-gateway service instead
since the workflows concern that.
We use "{{justfile_directory()}}/../.." to point to the repo root so
that the linter can find the .github/workflows folder containing
GitHub actions that run the otel gateway tests.

@rebkwok rebkwok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if we should put the justfile.base at the top level, so it could be more easily used by multiple subdir justfiles, but it seems unlikely we'll every add anything to the repoupdater that would need it, and the otel-gateway may go to its own repo sometime, so I think it's fine where it is

@alarthast

Copy link
Copy Markdown
Contributor Author

Yes, I briefly considered that a bit but I think keeping it all in the gateway seems a bit easier for it to be moved 👍

@alarthast
alarthast merged commit 0875965 into main Nov 12, 2026
4 checks passed
@alarthast
alarthast deleted the alarthast/lock-down-docker branch November 12, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants