Repository navigation
Lock down Docker containers used for local tooling - #301
Merged
Merged
Conversation
We don't need this recipe for repoupdater - none of the workflows involve it. We can add the recipe to the otel-gateway service instead since the workflows concern that.
We use "{{justfile_directory()}}/../.." to point to the repo root so
that the linter can find the .github/workflows folder containing
GitHub actions that run the otel gateway tests.
rebkwok
approved these changes
Nov 12, 2026
rebkwok
left a comment
Contributor
There was a problem hiding this comment.
I wondered if we should put the justfile.base at the top level, so it could be more easily used by multiple subdir justfiles, but it seems unlikely we'll every add anything to the repoupdater that would need it, and the otel-gateway may go to its own repo sometime, so I think it's fine where it is
Contributor
Author
|
Yes, I briefly considered that a bit but I think keeping it all in the gateway seems a bit easier for it to be moved 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/opensafely-core/security/issues/106.