Skip to content

Refactor scripts to tested package - #72

Closed
shimwell wants to merge 118 commits into
openmc-dev:masterfrom
openmc-data-storage:main
Closed

shimwell wants to merge 118 commits into
openmc-dev:masterfrom
openmc-data-storage:main

Conversation

@shimwell

@shimwell shimwell commented Jul 1, 2022 •

Copy link
Copy Markdown
Member

Just making this PR to see if people want to move this collection of scripts in the direction of a Python package, no worries if this is not wanted but I am keen to offer.

This has a few improvements over the current collection, addressing issues #5 #65 #69

  • more testing
  • more reuse of duplicate code
  • easier for users to install
  • offers new category of scripts (download only, no processing)
  • improved documentation

shimwell and others added 30 commits February 15, 2022 17:42
…options_to_deplete

added 2021 tendl depletion option
…n_try_2

Refactor to share extract function try 2
Merge pull request #4 from shimwell/combine_urls_to_ease_testing
@paulromano

Copy link
Copy Markdown
Contributor

Thanks for proposing these changes, @shimwell. I'm still of the mind that putting all this into a proper package is overkill. In practice, the only time we (OpenMC dev team) run these scripts is when there's either a new release of a data library or a change in our HDF5 format that requires we regenerate things. They have never really been intended as "user" scripts; rather, we put them here as an example to users in case they have their own specific needs for processing (i.e., they could take one of these scripts and modify for their own needs). Users who just want the results of running these scripts should download our pregenerated libraries available on openmc.org. I'm open to some of the changes within (adding some simple testing, e.g.) but don't feel that the added complexity in this PR is really worth it for what's intended to be a simple set of scripts that we run on occasion (the KISS principle comes to mind).

@shimwell

shimwell commented Jul 5, 2022

Copy link
Copy Markdown
Member Author

No worries, I wanted to offer the fork back to the original repo just in case. Totally understand that you want to keep things simple on this repo. I shall keep you posted if I think it is ever worth another look and if you see anything in particular over on the fork then ping me and I'll get it separated out and we can copy it over.

@shimwell shimwell closed this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a package Adding different tendl library versions to the depletion script We need CI for these scripts

2 participants