Repository navigation
Add retry behaviour #772
Description
Is your feature request related to a problem? Please describe.
Connections and API responses are flakey at times. A built-in retry mechanism could improve the success of responses.
Describe the solution you'd like
Use https://github.com/jd/tenacity (or similar) to add retry-behaviour.
Activity
dbanty commentedon Jul 7, 2023
I'm going to consider #775 as fixing this since you will be able to use the built-in httpx retries as well as reuse client connections when doing other retries (a la tenacity). I think retries tend to be super specific to each use-case, so adding a default opinionated mechanism in every client probably won't be super useful.
imadmoussa1 commentedon Jul 19, 2023
The httpx retries only manage connection failure . will we be considering adding something more custom httpx retry requests to the generator ?
dbanty commentedon Jul 23, 2023
@imadmoussa1 I think desired retry behavior is going to depend a lot on the application and the API—I'd assume that most folks creating SDKs for an API would like to build in their recommended retry behavior 🤔. If there's enough demand for it, we could add some sort of retry config for certain responses (specifically, those which include a
Retry-Afterheader, just to avoid folks having to includetenacityas a dependency for common cases.