Skip to content

Make generated Client and AuthenticatedClient take an httpx.Timeout object optionally? #745

Closed

Description

@mdlam92

I find myself making a wrapper for the Client object to implement taking an httpx.Timeout object.

It would be cool if the generated Client objects took an float as it does today but also accepted the httpx.Timeout type for the timeout keyword argument.

httpx's Timeout is nice because it lets you configure specific timeouts for read/write/connect/global.

I'm willing to make the PR, wanted to gauge interest or if the maintainer will consider this before I go and do it.

Activity

  1. emann commented on Apr 27, 2023

    @emann
    Contributor

    Should be a pretty simple change, just tweaking the type hints as far as I can tell. This may be better served waiting until #202 is implemented, however

  2. added this to the 0.15.0 milestone on Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions