Repository navigation
Reserved word 'Abstract' used in PropertyEnumeration.php #102
Description
Method OrderItem::setAttendeeDetailsRequired() expects an argument of type \OpenActive\Enums\PropertyEnumeration[] or null passing it an array of instances of Enums (GivenName & FamilyName) generates this syntax error:
PHP Parse error: syntax error, unexpected 'Abstract' (T_ABSTRACT), expecting identifier (T_STRING) in .../vendor/openactive/models/src/Enums/PropertyEnumeration.php on line 88
Line 88 of \OpenActive\Enums\PropertyEnumeration attempts to declare a const called Abstract, which isn't allowed.
Activity
drinkynet commentedon Jun 8, 2022
It also doesn't like the use of Yield on line 1533
drinkynet commentedon Jun 8, 2022
Commenting out lines 88 and 1533 lets it work as a quick and dirty fix.
nathansalter commentedon Jun 8, 2022
This will also happen for any of the reserved PHP words https://www.php.net/manual/en/reserved.keywords.php
After removing words which I feel are unlikely, the list is this:
We should put something in the model generator library to do something else here.
nathansalter commentedon Jun 8, 2022
Worth noting that:
Works in PHP 8.0+, but fails in earlier PHP versions. Calling
$t = new OpenActive\Enums\PropertyEnumeration\Abstract;never works.