Repository navigation
Conversation
testGetDateValue and testGetDatetimeValue compared the parsed values with values built by Date.newInstance and Datetime.newInstanceGmt. Those constructors read the year in the running user's calendar: for a th_TH user, Date.newInstance(2011, 3, 22) is 1468-03-22, while Date.valueOf and Datetime.valueOfGmt keep the year written in the ISO string, so both tests failed for a user with the Thai locale. Compare the GMT string form of each parsed value with the expected date and time instead, so the tests pass for a user in any locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testGetDateValue and testGetDatetimeValue compared the parsed values with values built by Date.newInstance and Datetime.newInstanceGmt. Those constructors read the year in the running user's calendar: for a th_TH user, Date.newInstance(2011, 3, 22) is 1468-03-22, while Date.valueOf and Datetime.valueOfGmt keep the year written in the ISO string, so both tests failed for a user with the Thai locale.
Compare the GMT string form of each parsed value with the expected date and time instead, so the tests pass for a user in any locale.