Skip to content

Changing how the LFP Viewer deals with subprocessors #302

Closed

Description

@ethanbb

To preface, this will all probably be obsolete when we have the streams/probes system (#266), but it's also relevant for what my lab is planning in the near future.

I want to revisit the issue of showing TTL events from Network Events (or other potential sources that provide events with no related continuous data) brought up in PR #277. The problem is that the LFP viewer determines how many samples to draw for each event channel from the samples in its source subprocessor, but these events don't have a real source subprocessor. Instead, currently the Network Events plugin has a dummy subprocessor with no data channels that always provides 0 samples, thus 0 event samples get written.

However, since the viewer is really only supposed to show one subprocessor at a time, it should be unambiguous how many samples are in the current buffer. So by making that actually be the case (by selecting source ID and subproc ID rather than just the latter in the LFP viewer combobox), we can save the full source subproc ID that is being viewed and use that as a default.

The downside is that you wouldn't be able to view data from multiple sources in one LFP viewer simultaneously. I'm actually impressed that it doesn't seem to crash when doing that currently, although if the sample rates are different, of course it doesn't display correctly since we're not doing resampling. Anyway, if there's a "zipper" module coming up in the new system, my understanding is that would make this possible again as long as the sources have the same sample rates.

My question is, does this sound like an improvement that would be good to submit for a PR to development, or would it break things other people are doing too much and we should just keep it on our fork?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions