Repository navigation
test: the two remaining #220 flakes under -race and load - #256
Merged
Merged
Conversation
added 3 commits
November 10, 2026 21:44
The rebuild still has to work in short batches: at most 5% may pass 50ms and none 500ms, instead of every one under 50ms.
A connect fails as soon as pion reports failed or closed, and otherwise has 60s, past pion's own 25s ICE failure timeout, with the ICE state on failure.
CI saw one honest batch over 500ms; 1s is the bound a publish during the rebuild already gets, and an unbatched rebuild holds the writer for seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220
Summary
TestIndexLifecycle_KilledMidRebuildResumes: allows up to 5% of index transactions over 50ms on a loaded machine, and fails any over 1s (CI has stalled an honest batch past 500ms).huddle/sfu: the connect wait follows pion's connection state. It fails at once onfailed/closed, otherwise gives pion's 25s ICE timeout room (60s), and reports the ICE state.cli/relaylogger race) was already fixed in test: wait on conditions, not on the clock (bunker, tui) #210.Test plan
go test -race -count=3 ./huddle/sfu/go test -short -race ./...: all pass-short -racesuites + the sfu tests x5) on main: no failures, so the sfu fix targets the reported state (connectingat 20s), not a local repro