Skip to content

test: the two remaining #220 flakes under -race and load - #256

Merged
naliyi merged 3 commits into
mainfrom
fix/flaky-race-tests
Nov 10, 2026
Merged

naliyi merged 3 commits into
mainfrom
fix/flaky-race-tests

Conversation

@naliyi

@naliyi naliyi commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #220

Summary

  • climatrix TestIndexLifecycle_KilledMidRebuildResumes: allows up to 5% of index transactions over 50ms on a loaded machine, and fails any over 1s (CI has stalled an honest batch past 500ms).
  • huddle/sfu: the connect wait follows pion's connection state. It fails at once on failed/closed, otherwise gives pion's 25s ICE timeout room (60s), and reports the ICE state.
  • The third flake (cli/relay logger race) was already fixed in test: wait on conditions, not on the clock (bunker, tui) #210.

Test plan

wingha added 3 commits November 10, 2026 21:44
The rebuild still has to work in short batches: at most 5% may pass 50ms
and none 500ms, instead of every one under 50ms.
A connect fails as soon as pion reports failed or closed, and otherwise has
60s, past pion's own 25s ICE failure timeout, with the ICE state on failure.
CI saw one honest batch over 500ms; 1s is the bound a publish during the
rebuild already gets, and an unbatched rebuild holds the writer for seconds.
@naliyi
naliyi marked this pull request as ready for review November 10, 2026 22:19
@naliyi naliyi mentioned this pull request Nov 10, 2026
2 tasks done
@naliyi
naliyi merged commit a93bf67 into main Nov 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Three tests flaky under -race on a loaded machine: climatrix index lifecycle, huddle/sfu connect, cli/relay logger race

1 participant