Skip to content

Accept a project's own logo and favicon - #2

Merged
naliyi merged 1 commit into
mainfrom
feat/logo-favicon-inputs
Oct 19, 2026
Merged

naliyi merged 1 commit into
mainfrom
feat/logo-favicon-inputs

Conversation

@naliyi

@naliyi naliyi commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Closes #1

Summary

  • New optional inputs: logo, logo-dark, logo-replaces-title, favicon (paths in the calling repo).
  • Without them the site is unchanged: the glyph favicon is still generated.

Test plan

  • Local build against ncli with DOCS_LOGO/DOCS_FAVICON: header shows the logo in light and dark, /favicon.svg is the project's file
  • Local build without them: glyph favicon generated, no logo

@naliyi naliyi mentioned this pull request Oct 19, 2026
4 tasks done
@naliyi
naliyi marked this pull request as ready for review October 19, 2026 11:05
@naliyi
naliyi merged commit 6c1392d into main Oct 19, 2026
1 check passed
@naliyi
naliyi deleted the feat/logo-favicon-inputs branch October 19, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept a project's own logo and favicon

1 participant