Skip to content

fix(my_profile): make mouse clicks land on the right row and footer keys - #605

Open
pcoldico wants to merge 30 commits into
odpi:mainfrom
pcoldico:main
Open

pcoldico wants to merge 30 commits into
odpi:mainfrom
pcoldico:main

Conversation

@pcoldico

Copy link
Copy Markdown
Contributor

Summary

Fixes two mouse problems in My Profile:

  • Clicking a table row selected the row above the pointer.
  • Clicking a footer hotkey did nothing (the keyboard shortcut worked).

Cause

Textual 8 turns on pixel-precise mouse reporting in terminals that support in-band resize. In some terminals, converting those pixel positions to rows came out one row too high. Every click then hit the row above the pointer. Footer clicks landed on the row above the footer, so they never reached it. The CSS wasn't the cause: a headless test with the real my_profile.tcss hit-tests correctly.

Fix

my_profile.py sets textual.constants.SMOOTH_SCROLL = False at import time, which turns that mode off. If TEXTUAL_SMOOTH_SCROLL is set explicitly, that setting wins. The fix works under both textual run and the my_profile command. It was confirmed by hand in the affected terminal.

Also included

  • Layout clean-up in my_profile.tcss, MainScreen, the Projects/Project and Communities/Community screens, and the splash screen.
  • Enter opens a project, or gives feedback on a post or resource, in the Projects and Community screens.
  • Actions use the last-active table when no table has focus.
  • Edit Table resolves the row from the cursor more reliably.
  • Footer-click and key tests for MainScreen.

Test plan

  • pytest tests/micro-tests/my_profile: 748 passed, 1 skipped
  • Manual: row selection and footer clicks work in the terminal where the bug showed up

🤖 Generated with Claude Code

pcoldico and others added 30 commits October 30, 2026 08:18
…s that make up the app

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
… consistent screen titles, show persons not roles in communities, etc.

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…n on the main screen

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Sync between Local and Github branches of egeria-python
Merge local repo with Upstream Main repo
Merge local repo copy with upstream main
- Move all My Profile screens, handlers, styles, and assets from DemoCode into my_egeria/my_egeria/
- Standardize core application module as my_profile.py and update package entry points
- Update tests, root configs, and guides to reference production my_profile
- Refresh VIDEO_SCRIPT_DRAFT.md with current features in the Jules Keeper video series style

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Co-authored-by: Junie <junie@jetbrains.com>
… Profile

- Implement VHS tape scripts, headless Textual Pilot driver, and runner scripts for 1080p demo captures
- Add neural voiceover generation and video assembly pipeline with FFmpeg duration alignment and slide cards
- Update SplashScreen with multi-key dismissal bindings and refresh VIDEO_SCRIPT_DRAFT.md

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Co-authored-by: Junie <junie@jetbrains.com>
- Add all generated narrated videos, walkthrough clips, and master video blog episode
- Add all scene audio tracks, animated GIFs, 1080p slide cards, and PNG/SVG captures
- Remove local recording .gitignore to ensure full output directory tracking

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Co-authored-by: Junie <junie@jetbrains.com>
Resolves the add/add conflict in my_egeria/my_egeria/VIDEO_SCRIPT_DRAFT.md
by keeping this PR's newer draft (16:40 on 2026-11-10, after odpi#580's 10:30).

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
recording/output held ~119 MB of generated mp4, mp3 and png files
(the narrated walkthroughs are 21-27 MB each). The scripts recreate
the folder (generate_voiceover.py mkdirs it), so the scripts, tapes,
README and docs stay; only the output goes, and it is now ignored.
Host the finished videos outside the repo (YouTube or a release asset).

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Merge local repo with main repo on github
…uction

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>

# Conflicts:
#	my_egeria/my_egeria/CommunitiesScreen.py
#	my_egeria/my_egeria/community_handler.py
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…d paging

- My-Egeria-Doc.md: communities section rewritten (Find Community, open from
  User Associations, resources, join from a community, main-screen refresh,
  feedback on posts and resources); new "Paging and write guards" section for
  the 6.2.42 paging_support work; bookmarks, My Network, feedback log,
  subscriptions and collections descriptions corrected; stale key bindings
  fixed throughout; testing and known gaps updated.
- my_egeria_manual.md: troubleshooting for "at least N" and "Couldn't
  confirm ... Nothing was created" messages; community/feedback notes;
  Known Limitations dated 2026-11-17.
- release-notes/next.md: My Profile entry for odpi#601.
- RETURN_CODES.md: 210 includes the feedback screen.
- my_egeria/README.md: paging_support.py and the community/feedback screens.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
…screens and documentation

- Implement project_handler.py (ProjectsMixin) for project listing, search, creation, join/leave, member resolution, resource mapping, blog posts, and comments.
- Implement ProjectsScreen.py and ProjectScreen.py with Catppuccin Mocha TUI styling and keyboard shortcuts.
- Update MainScreen.py and my_profile.py to integrate 'Work with Projects' and 'Find Project' menu options and Enter row activation on the projects table.
- Add micro-test suite in test_project_handler.py.
- Update documentation in README.md, my_egeria_manual.md, My-Egeria-Doc.md, and developer_guide_pyegeria_textual.md.

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Co-authored-by: Junie <junie@jetbrains.com>
Textual 8 turns on pixel-precise mouse reporting in terminals that
support in-band resize. In some terminals, converting those pixel
positions to rows came out one row too high, so every click hit the row
above the pointer: tables selected the line above, and footer hotkeys
never fired because the click landed on the row above the footer.

my_profile.py now turns that mode off at import time
(textual.constants.SMOOTH_SCROLL = False, unless TEXTUAL_SMOOTH_SCROLL
is set explicitly), which works under both `textual run` and the
`my_profile` command.

Also included:
- Layout clean-up in my_profile.tcss, MainScreen, the Projects/Project
  and Communities/Community screens, and the splash screen.
- Enter opens or gives feedback in the Projects and Community screens.
- Actions use the last-active table when no table has focus.
- Edit Table resolves the row from the cursor more reliably.
- Footer-click and key tests for MainScreen.

Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>

# Conflicts:
#	my_egeria/my_egeria/MainScreen.py
#	my_egeria/my_egeria/ProjectScreen.py
#	my_egeria/my_egeria/ProjectsScreen.py
#	my_egeria/my_egeria/my_profile.tcss

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants