Repository navigation
fix: document expectedValue as bookmaker/fair x 100, bump to 1.2.1 - #13
Merged
Merged
Conversation
expectedValue is bookmaker odds / fair odds x 100 (103.42 = 3.42% edge), not a fraction. Fixes the value_bets example, the ValueBet and get_value_bets docstrings and the README snippet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/value_bets.pysaidexpectedValueis a fraction (0.0523 = 5.23%) and printedexpectedValue * 100. The API returns bookmaker odds / fair odds x 100: values cluster around 100, 103.42 is a 3.42% edge, below 100 is a negative edge. The example now prints and filters onexpectedValue - 100.ValueBetTypedDict docstring andget_value_betsdocstrings (sync and async) explain the unit.profitMarginis already a percentage.__version__, CITATION.cff, README citation), CHANGELOG. The fair-odds notebook computes its own EV and was already correct.Test plan
pytest(110 passed)