Repository navigation
Conversation
|
addresses #19 if u wanna do this differently lmk but i think it's fine realistically |
| elif loaded[key] != name: | ||
| errors.append("extension %s: zphp reports it as %s" % (name, loaded[key])) | ||
| for name in available.values(): | ||
| expected = sorted(manifest["extensions"][name]["functions"], key=str.lower) |
There was a problem hiding this comment.
Isn't this comparison circular? expected comes from the manifest, while get_extension_funcs() gets its built in function list from extensions_generated.zig, which is generated from that same manifest.
This seems unable to catch a function being assigned to the wrong extension, should extension ownership also be checked against the reference php inventory?
There was a problem hiding this comment.
Working on getting php-src tests to pass (as much as they can). As soon as that work is done, I'll pivot to this
There was a problem hiding this comment.
Still on my radar. Tests are at 98% pass. So close. Once it's done, I'm moving back to this.

No description provided.