Skip to content

extra set of wrappers and refactors - #19

Merged
0xbase12 merged 13 commits into
masterfrom
module-data-infra-wraps
Jun 8, 2020
Merged

0xbase12 merged 13 commits into
masterfrom
module-data-infra-wraps

Conversation

@konstan

@konstan konstan commented May 29, 2020

Copy link
Copy Markdown
Contributor
  • resource wrappers: module, data, infra
  • refactored deployment, added data related bits
  • added client-server chit-chat printout
  • other refactors

- refactored deployment, added data bits
- added client-server chit-chat printout
- other refactors
@konstan
konstan requested a review from 0xbase12 May 29, 2020 06:20
@konstan
konstan marked this pull request as draft May 29, 2020 06:21
@konstan
konstan removed the request for review from 0xbase12 May 29, 2020 06:22
@konstan
konstan marked this pull request as ready for review June 5, 2020 06:52
@konstan
konstan requested a review from 0xbase12 June 5, 2020 06:52
@konstan

konstan commented Jun 5, 2020

Copy link
Copy Markdown
Contributor Author

@0xbase12
The main part to look at are the changes in Api and Deployment modules as they are the ones that
I was changing and they'd are mostly used everywhere else. There seems to be no regressions as this was validated to be working during the demo on job distributors for deployment state.
I didn't run any validations around NBs yet. I will do that when the code is in master and provide fixes if need be.

Comment thread code/src/nuvla/api/api.py

def _request_debug(method, endpoint, params=None, doc=None,
data=None, headers: Optional[dict]=None):
# TODO: Use logging library.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konstan There is a todo in the pull-request. Is it for later?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xbase12 Yes, this is for later.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xbase12
0xbase12 merged commit e63d2d0 into master Jun 8, 2020
@0xbase12
0xbase12 deleted the module-data-infra-wraps branch June 8, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants