Repository navigation
Extend cython to cover inserts as well - #207
Open
TheDistributor wants to merge 2 commits into
Open
TheDistributor wants to merge 2 commits into
TheDistributor wants to merge 2 commits into
Conversation
TheDistributor
marked this pull request as ready for review
October 7, 2026 14:30
pflynnnuodb
reviewed
Oct 7, 2026
| NUODB_INLINE int _pynuodb_clz64(unsigned long long x) | ||
| { | ||
| unsigned long idx; | ||
| _BitScanReverse64(&idx, x); |
There was a problem hiding this comment.
Does this need to work on 32-bit systems?
Contributor
Author
There was a problem hiding this comment.
what's a 32 bit system??
pflynnnuodb
reviewed
Oct 7, 2026
Comment on lines
+14
to
+18
| `cryptography` is a required dependency: sessions are always encrypted, and | ||
| without it the driver falls back to a pure-Python RC4 implementation that is | ||
| dramatically slower (an O(n) Python byte loop over every wire message) -- | ||
| slow enough to dominate the cost of any batch insert/select, masking | ||
| unrelated performance work. Installing pynuodb always pulls it in. |
There was a problem hiding this comment.
You might want to run this change by our Release team.
|
Are the benchmark results a bit underwhelming? I seem to remember the other ones being a lot better. |
pflynnnuodb
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend cython acceleration to cover the write path as well.
Add new 'encode_batch_rows' and 'decode_batch_results' native methods to accelerate inserts and decoding of batch insert results.
Mark 'cryptography' as a require dependency as performance is just too slow without it and it led me down the garden path at least twice with this changeset.
Extend tests with many more correctness tests.
Extend benchmark tests with more tests for scaled and binary types.
Impact on performance according to the benchmarks run against the branch by CircleCI: