Repository navigation
Versions upgrade - #225
Merged
Merged
Versions upgrade#225
Conversation
aviadhahami
force-pushed
the
chore/version-upgrades
branch
from
May 11, 2023 14:31
5e9dc5f to
16c2813
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #225 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 147 140 -7
Branches 37 0 -37
=========================================
- Hits 147 140 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aviadhahami
force-pushed
the
chore/version-upgrades
branch
from
May 11, 2023 14:59
7071a9e to
52578aa
Compare
aviadhahami
force-pushed
the
chore/version-upgrades
branch
from
May 11, 2023 15:05
52578aa to
b6ff10e
Compare
Signed-off-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
aviadhahami
added a commit
that referenced
this pull request
Oct 11, 2026
…n schemas
addKubernetesRole and certLogin threw "TypeError: Cannot convert undefined
or null to object" whenever they were given any argument, and have done so
since both were added in 0.10.0 (first published in 0.9.23-canary.1).
extendOptions builds the request body from schema.req.properties, and
neither schema had one: addKubernetesRole's fields sat directly under req,
and certLogin's req was a bare { type: 'object' }.
- addKubernetesRole: the schema now declares the role parameters of Vault's
Kubernetes auth API, per its OpenAPI spec: the current token_*, audience,
alias_name_source, alias_metadata and namespace-selector fields, plus the
deprecated aliases it already had (policies, ttl, max_ttl, period,
num_uses, bound_cidrs). As in Vault, list fields take an array or a
comma-separated string and durations take seconds or a duration string.
Undeclared keys are never sent, so declaring only the legacy names would
have dropped token_bound_cidrs, audience and the rest without an error.
The unused `name` field is gone: the role name is role_name in the path.
- certLogin: declare the optional `name` (the certificate role to match).
- generateRootStatus (GET /sys/generate-root/attempt): restored exactly as
it was in 0.9.22. The 0.10.0 lint merge (#225) dropped it, and 0.11.0
then removed its dangling type declaration, which is restored too.
- features.md regenerated (adds generateRootStatus).
New unit tests cover the three commands, and a guard test checks that every
command's req/query schema declares type 'object' with properties, which
would have caught both schema bugs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's time to move forward :)