Skip to content

Versions upgrade - #225

Merged
aviadhahami merged 14 commits into
masterfrom
chore/version-upgrades
May 11, 2023
Merged

aviadhahami merged 14 commits into
masterfrom
chore/version-upgrades

Conversation

@aviadhahami

Copy link
Copy Markdown
Collaborator

It's time to move forward :)

@aviadhahami aviadhahami changed the title Version upgrade Versions upgrade May 11, 2023
@aviadhahami
aviadhahami force-pushed the chore/version-upgrades branch from 5e9dc5f to 16c2813 Compare May 11, 2023 14:31
@codecov-commenter

codecov-commenter commented May 11, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #225 (b6ff10e) into master (0067632) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b6ff10e differs from pull request most recent head 5346a1a. Consider uploading reports for the commit 5346a1a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##            master      #225   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          147       140    -7     
  Branches        37         0   -37     
=========================================
- Hits           147       140    -7     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/commands.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aviadhahami
aviadhahami force-pushed the chore/version-upgrades branch from 7071a9e to 52578aa Compare May 11, 2023 14:59
@aviadhahami
aviadhahami force-pushed the chore/version-upgrades branch from 52578aa to b6ff10e Compare May 11, 2023 15:05
Aviad Hahami and others added 4 commits May 11, 2023 18:33
@aviadhahami
aviadhahami merged commit 9b708ae into master May 11, 2023
@aviadhahami
aviadhahami deleted the chore/version-upgrades branch May 13, 2023 21:01
aviadhahami added a commit that referenced this pull request Oct 11, 2026
…n schemas

addKubernetesRole and certLogin threw "TypeError: Cannot convert undefined
or null to object" whenever they were given any argument, and have done so
since both were added in 0.10.0 (first published in 0.9.23-canary.1).
extendOptions builds the request body from schema.req.properties, and
neither schema had one: addKubernetesRole's fields sat directly under req,
and certLogin's req was a bare { type: 'object' }.

- addKubernetesRole: the schema now declares the role parameters of Vault's
  Kubernetes auth API, per its OpenAPI spec: the current token_*, audience,
  alias_name_source, alias_metadata and namespace-selector fields, plus the
  deprecated aliases it already had (policies, ttl, max_ttl, period,
  num_uses, bound_cidrs). As in Vault, list fields take an array or a
  comma-separated string and durations take seconds or a duration string.
  Undeclared keys are never sent, so declaring only the legacy names would
  have dropped token_bound_cidrs, audience and the rest without an error.
  The unused `name` field is gone: the role name is role_name in the path.
- certLogin: declare the optional `name` (the certificate role to match).
- generateRootStatus (GET /sys/generate-root/attempt): restored exactly as
  it was in 0.9.22. The 0.10.0 lint merge (#225) dropped it, and 0.11.0
  then removed its dangling type declaration, which is restored too.
- features.md regenerated (adds generateRootStatus).

New unit tests cover the three commands, and a guard test checks that every
command's req/query schema declares type 'object' with properties, which
would have caught both schema bugs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants