Repository navigation
Proposal for nightly code coverage run #36
Description
Activity
@nodejs/build
Hi @CurryKitten! :)
I believe @jbergstroem was already working on something in that direction?
I happy to help move this forward, create CI jobs, etc and pull in other build team members when necessary for pieces like pushing the files over to the website.
@mhdawson perhaps slap a label on the same hosts that run v8test (ish) and use those seeing how they have more cpu/ram to spare.
test-rackspace-fedora24-x64-1being a good example. We'd need a new playbook for required packages though.@jbergstroem the reason I was going to suggest the benchmarking machine is because as I understand the website needs to pull fro a known location.
@mhdawson sgtm as long as we can make sure there's no benchmarking going on.
Staring to integrate here:
https://ci.nodejs.org/job/node-test-commit-linux-coverage-mdawson/11/nodes=benchmark/consoleFull
Still work to do, adding bit by bit so that I understand, also modifying so that it is the same as our standard build job except for the additions required to generate the code coverage.
So far have added up to the point where it builds and runs the tests.
Ok, job is setup to run as documented here:
In the interim I have data being pushed here nodejs.devrus.com:8080 (one of my machines) so that people can see what it will look like.
@addaleax could you submit a PR adding these files to github.com/nodejs/testing/coverage:
gcovr-patches.diff
generate-index-html.py
patches.diffI'll then submit a PR for my updates to generate-index-html.py.
@jbergstroem, @rvagg can you review #37 and look at adding the pull from the benchmarking machine and serving the files as coverage.nodejs.org ? Just let me know if you need any additional information. The same key used to pull the charts for benchmarking.nodejs.org can be used to do the pull in a similar manner. The content will be at ~/coverage-out/out
Reacted by Anna HenningsenAs an FYI I also renamed the job to remove my name so its now: https://ci.nodejs.org/view/All/job/node-test-commit-linux-coverage/
- added a commit that references this issue
on Oct 12, 2016 done, live @ https://coverage.nodejs.org/, config @ nodejs/build#516
Reacted by Rich Trott@mhdawson Where are the files from which the https://coverage.nodejs.org/ is currently generated? There are still references to my github project, and idk if that should be fixed before making it something “official”… otherwise, yeah, you can feel free to send out anything you like :)
oh, btw, they are in coverage-out/out on benchmarking, that's where we are pulling from so if you fix that up let us know and we can adjust, happy to leave that as is if it doesn't bother you tho
@addaleax. Some of the files are still coming from your repo, with one having been modified and residing on the benchmarking machine. Once we land your PR I'll commit the changed file there 2.
Once that happens I'll get you to take another look to make sure all of the references are gone and then send something out.
@rvagg once they are fixed up it should automatically update the files in coverage-out/out on the benchmarking data machine.
Reacted by Anna Henningsen- added a commit that references this issue
on Nov 1, 2016 https://coverage.nodejs.org/ looks good to me, yep 👍
Announced via weekly update. Improved via comments/updates from website group. My next step is to update the documentation. I know @CurryKitten is working on moving more into core in order to avoid possible conflicts in the future.
I think is done via coverage.nodejs.org so closing. Comment or re-open if I'm missing something!
We'd like to get code coverage run every night and published to codecoverage.nodejs.org
There has been some great work done already as discussed in:
#31
To produce these coverage results, we believe the steps are as follows:
If we agree this is the right thing to do and we should move forward I'll volunteer to start working on these steps. I've talked to @mhdawson and he can help out with the parts that require creating jenkins jobs.
FYI @addaleax, @Trott