Repository navigation
Do not parse numbers on url parsers - ipv4 #36
Description
Activity
So basically instead of
int64_t num = ParseIPv4Number(last_str, last_str + last.size());we would just use a validator here?There are 2 optimizations can be done here.
- Removing vector initialization on line 412
std::vector<std::string> parts = SplitString(input, '.', false);- Removing ParseIPv4Number and replacing it with a validator that returns boolean
int64_t num = ParseIPv4Number(last_str, last_str + last.size());Understood! Thanks! will attempt this!
- added a commit that references this issue
on Jan 16, 2023 I'm really sorry @debadree25 ! : ((
I was already working on it and should have commented something here.
I apologize for thatReacted by Debadree Chatterjee and Tony GorezI'm really sorry @debadree25 ! : (( I was already working on it and should have commented something here. I apologize for that
No issue at all checking out your PR to learn!!
Reacted by Miguel Teixeira and Tony Gorez- added a commit that references this issue
on Jan 23, 2023 - added a commit that references this issue
on Feb 1, 2023
EndsInNumberparses the number, but does not use the result of it. Just using the validations, without the parsing, would make ipv4 parsing 28% faster.Similar comparison is: ada-url/ada#36