Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ndencies Signed-off-by: Aleksey Shestakov <alshestakov25@gmail.com>
alexicum
force-pushed
the
fix/ui-components-peer-react
branch
from
September 30, 2026 06:45
df650c2 to
9301469
Compare
Member
|
@avivkeller wdyt about this? Does it make sense? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9176 +/- ##
==========================================
- Coverage 86.12% 86.11% -0.02%
==========================================
Files 86 86
Lines 6041 6041
Branches 357 357
==========================================
- Hits 5203 5202 -1
- Misses 834 835 +1
Partials 4 4 ☔ View full report in Codecov by Harness. |
Contributor
📦 Build Size ComparisonSummary
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
ui-componentspackage hadreactlisted underdependencies. When published, this metadata structure forces consumer applications running a different sub-version of React 19 to install a duplicate instance of React, triggering runtimeInvalid hook callerrors.Changes
To resolve external runtime duplication while preserving strict React 19 compatibility and seamless local workspace development, this PR applies the following:
reacttopeerDependenciesinpackages/ui-components/package.jsonusing thecatalog:peer-react19protocol to delegate runtime React resolution to the host/consumer application.reactindevDependenciesto guarantee that local package builds (pnpm build), test utilities, and TypeScript types compilation inside the isolated package directory do not break.pnpm-workspace.yaml): Configuredcatalog:peer-react19to target a loose^19.0.0range. When the library is published, pnpm will substitute the catalog protocol with a standard open SemVer range (^19.0.0) matching any consumer's native React 19 installation..changeset/cozy-teeth-speak.md) to comply with the workspace publishing policy.Fixes #9175