You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Docs: Default es6 features should clarify type of Spread operator #653
changed the title [-]Default es6 features should clarify type of Spread operator[/-][+]Docs: Default es6 features should clarify type of Spread operator[/+]on Apr 16, 2016
The issue isn't about whether object spread operators are included in ES2015 or not.
It's about the phrase "Spread Operator" being ambiguous for anybody who doesn't know off the top of their head what is or isn't part of any given standard.
When I look at a list of supported features in my version of node, I don't care if it is in ES2015 or ES2017. I just want to know if I should be able to use it or not.
I don't understand why the related PR was getting rejected. I don't see why adding a little note to clarify that object spread operators are not supported, is so controversial that it must not be pointed out to readers seeking information about it.
@batjko the reason is that v5 will be end of life once v6 is released next week, which has better support for the spread operator. If we added the change we would have to revert it next week
Actually the note was generic enough to not include the fact that spread operator did not work on destructuring assignments. Destructuring in not available in node 5 anyway.
The reason is that spread operator documentation already makes it clear that it only works on array literals, function calls and destructuring so the note is redundant imho.
Also as @fhemberger stated above, there is an ongoing work to create an "ES6 and beyond" page that should replace the current "ES6 in Node.js" page.
That seems a better place to put notes about future features of the language.
Ah, Another thing I wasn't aware of, @thealphanerd . That of course makes total sense to me.
I suppose my concern was simply that the generic phrasing simply assumes that everyone keeps closely up-to-date with all features and at which stage of their discussion / implementation they are at any given point.
A lot of people just don't have the time to do that, so clarity is always preferable to "you should have read these other documents".
But either way, it's going to be brought up-to-date with v6 anyway, so it's all good.
Thanks everyone.
Activity
[-]Default es6 features should clarify type of Spread operator[/-][+]Docs: Default es6 features should clarify type of Spread operator[/+]lpinca commentedon Apr 18, 2016
I've filed a pr for this, but I think the issue is invalid. The feature is not part of ES2015.
batjko commentedon Apr 18, 2016
The issue isn't about whether object spread operators are included in ES2015 or not.
It's about the phrase "Spread Operator" being ambiguous for anybody who doesn't know off the top of their head what is or isn't part of any given standard.
When I look at a list of supported features in my version of node, I don't care if it is in ES2015 or ES2017. I just want to know if I should be able to use it or not.
Thanks for the PR, @lpinca.
fhemberger commentedon Apr 18, 2016
@lpinca There is an open issue to rename that page to "ES6 and beyond", so it's still okay.
lpinca commentedon Apr 18, 2016
Ok.
stevemao commentedon Apr 20, 2016
Closing as #661 is closed
batjko commentedon Apr 20, 2016
I don't understand why the related PR was getting rejected. I don't see why adding a little note to clarify that object spread operators are not supported, is so controversial that it must not be pointed out to readers seeking information about it.
stevemao commentedon Apr 20, 2016
Reason already stated in the PR.
MylesBorins commentedon Apr 20, 2016
@batjko the reason is that v5 will be end of life once v6 is released next week, which has better support for the spread operator. If we added the change we would have to revert it next week
lpinca commentedon Apr 20, 2016
Actually the note was generic enough to not include the fact that spread operator did not work on destructuring assignments. Destructuring in not available in node 5 anyway.
The reason is that spread operator documentation already makes it clear that it only works on array literals, function calls and destructuring so the note is redundant imho.
lpinca commentedon Apr 20, 2016
Also as @fhemberger stated above, there is an ongoing work to create an "ES6 and beyond" page that should replace the current "ES6 in Node.js" page.
That seems a better place to put notes about future features of the language.
batjko commentedon Apr 20, 2016
Ah, Another thing I wasn't aware of, @thealphanerd . That of course makes total sense to me.
I suppose my concern was simply that the generic phrasing simply assumes that everyone keeps closely up-to-date with all features and at which stage of their discussion / implementation they are at any given point.
A lot of people just don't have the time to do that, so clarity is always preferable to "you should have read these other documents".
But either way, it's going to be brought up-to-date with v6 anyway, so it's all good.
Thanks everyone.