Skip to content

All page title is "<title>Node.js</title>" #5141

Description

@azu

URL:

https://nodejs.org/en/blog/release/v19.8.0

Browser Name:

Chrome

Browser Version:

111.0.5563.64

Operating System:

macOS

How to reproduce the issue:

  1. Visit https://nodejs.org/en/blog/release/v19.8.0
  2. See <title> and get "Node.js" instead of "Node v19.8.0 (Current)"

Now, Almost page title is "Node.js".

https://nodejs.org/en/
https://nodejs.org/en/about/
https://nodejs.org/en/download/
https://nodejs.org/en/docs/
https://nodejs.org/en/get-involved/
https://nodejs.org/en/blog/

image

Activity

  1. ovflowd commented on Mar 15, 2023

    @ovflowd
    Member

    This is not a bug. https://github.com/nodejs/nodejs.org/blob/main/components/HtmlHead.tsx#L19, it is expected to all pages to just have Node.js as title. If you want that to change, please submit a feature request.

  2. azu commented on Mar 15, 2023

    @azu
    Author

    Fmm, Previously Node.js blog use article title.
    I think it is regression bug.

    <meta property="og:title" content={pageTitle} />

    og:title use pageTitle.

    https://www.google.co.jp/search?q=site:nodejs.org/en/blog/
    https://web.archive.org/web/20230301001519/https://nodejs.org/en/

    Previous

    Probably

    {pageTitle ? `${pageTitle} | ${siteConfig.title}` : siteConfig.title}
    
  3. qnighy commented on Mar 15, 2023

    @qnighy

    Original implementation before #4991 seems to have been:

    <title>{{#if title}}{{ title }} | {{/if}}{{ site.title }}</title>

  4. ovflowd commented on Mar 15, 2023

    @ovflowd
    Member

    I wouldn't consider that a bug, but indeed a regression. Spot on! Let me reopen this issue :)

  5. ovflowd commented on Mar 15, 2023

    @ovflowd
    Member

    Working on a PR. Hold tight fellas!

  6. azu commented on Mar 15, 2023

    @azu
    Author

    @ovflowd Thanks!

    Opps, I create same PR
    #5142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions