Repository navigation
src: fix use-after-free in v8 inspector - #7490
Closed
bnoordhuis wants to merge 1 commit into
Closed
bnoordhuis wants to merge 1 commit into
bnoordhuis wants to merge 1 commit into
Conversation
AgentImp::OnInspectorHandshakeIO() should not delete the socket because its caller, data_received_cb(), takes care of that.
bnoordhuis
added
the
inspector
nodejs-github-bot
added
the
c++
Contributor
|
@bnoordhuis is there no instance where handshake fails and there is an instance of the socket? |
Member
Author
|
Fixed by 08aff14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@ofrobots or @pavelfeldman
CI: https://ci.nodejs.org/job/node-test-pull-request/3132/