Skip to content

test: change forEach to for of loop - #66547

Open
realnumber1forever wants to merge 2 commits into
nodejs:mainfrom
realnumber1forever:main
Open

realnumber1forever wants to merge 2 commits into
nodejs:mainfrom
realnumber1forever:main

Conversation

@realnumber1forever

@realnumber1forever realnumber1forever commented Oct 6, 2026 •

Copy link
Copy Markdown

Fixed previous issues hopefully

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@MikeMcC399

MikeMcC399 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

See Commit message guidelines according to the Pull requests documentation.

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin.

Instead of replacing the first commit, you have added a new one. It says:
Signed-off-by: unknown empower3125@gmail.com

which does not match the username of the committer.

@MikeMcC399

Copy link
Copy Markdown
Contributor

Fixed previous issues hopefully

Please replace with a meaningful description

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (9746ebc) to head (ebe9ee3).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66547   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         791      791           
  Lines      276120   276120           
  Branches    53022    53022           
=======================================
+ Hits       249618   249622    +4     
- Misses      16897    16906    +9     
+ Partials     9605     9592   -13     

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399

Copy link
Copy Markdown
Contributor

This looks like it was part of a teaching exercise. Please either complete it or close it.

cc: @avivkeller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants