quic/stream: create gen. getWriter for stream/iter - #66513
martenrichter wants to merge 1 commit into
Conversation
|
Review requested:
|
|
@jasnell @pimterry |
|
P.S.: There seem to be some bugs remaining. (I thought I had run all tests, but it seems that I only ran lint and not a full build.) But discussing the structure should work anyway. |
2f1920c to
40db343
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66513 +/- ##
=======================================
Coverage 90.41% 90.42%
=======================================
Files 791 790 -1
Lines 275567 275487 -80
Branches 52835 52828 -7
=======================================
- Hits 249159 249099 -60
+ Misses 16813 16782 -31
- Partials 9595 9606 +11
🚀 New features to boost your workflow:
|
The get writer method of QuicStream is mostly generell enough to be usuable in other contexts. This PR is an attempt to move the code out of the QuicStream object to be usuable in other parts of node.js. Fixes nodejs#66508 Signed-off-by: Marten Richter <marten.richter@freenet.de>
40db343 to
69719cd
Compare
|
Ok, now, everything works according to the local tests. |
|
I do not understand the build failures. It complains about an unknown compiler option? Do I need to rebase? |
The get writer method of QuicStream is mostly
generell enough to be usuable in other contexts.
This PR is an attempt to move the code out
of the QuicStream object to be usuable in other
parts of node.js.
Fixes #66508