Skip to content

process: add --no-reset-stdio option - #66134

Closed
icecold009 wants to merge 1 commit into
nodejs:mainfrom
icecold009:codex/nodejs-terminal-reset-35536
Closed

icecold009 wants to merge 1 commit into
nodejs:mainfrom
icecold009:codex/nodejs-terminal-reset-35536

Conversation

@icecold009

Copy link
Copy Markdown

Fixes: #35536

Add a --no-reset-stdio option for processes that must preserve the terminal state established by the parent shell. The option state is copied into a lock-free atomic after command-line parsing because ResetStdio() can run from signal handlers.

Add a POSIX pseudo-TTY regression test covering terminal echo state after a child process exits.

Tests:

  • git diff --check
  • node --check test/pseudo-tty/test-no-reset-stdio.js
  • Not run: the pseudo-TTY test requires a POSIX environment and a locally built Node.js binary.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@MikeMcC399

Copy link
Copy Markdown
Contributor

See Commit message guidelines according to the Pull requests documentation.

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin.

@MikeMcC399

Copy link
Copy Markdown
Contributor

There is a conflict in this PR. Please rebase the branch in this PR according to the Pull requests documentation.

@MikeMcC399

Copy link
Copy Markdown
Contributor

Closing, as there has been no response to requests to change the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Background node process corrupts terminal state with tcsetattr() on exit

3 participants