Repository navigation
src: only disable PIE on OS X when -prof is passed - #6468
Closed
bnoordhuis wants to merge 2 commits into
Closed
bnoordhuis wants to merge 2 commits into
bnoordhuis wants to merge 2 commits into
Conversation
This is a follow-up to commit a5012a0 ("build: unbreak -prof, disable PIE on OS X") that disabled PIE (and therefore ASLR) completely on OS X. We now scan the command line options and re-exec the process with the _POSIX_SPAWN_DISABLE_ASLR flag set when `-prof` is specified. The options parser is smart enough to understand any combination of `-prof` and `-noprof`, including alternative spellings like `--no_prof`. Fixes: nodejs#6466
bnoordhuis
added
build
nodejs-github-bot
added
the
c++
Member
|
Nice! Will give it a review and test here in a bit |
Member
|
LGTM. CI is green. Local test run looks good too. @bnoordhuis ... Question: I'm not too familiar with |
Member
Author
|
@jasnell I've added a commit that does that. |
Member
Author
|
Closing, obsoleted by https://codereview.chromium.org/1934453003. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to commit a5012a0 ("build: unbreak -prof, disable
PIE on OS X") that disabled PIE (and therefore ASLR) completely on OS X.
We now scan the command line options and re-exec the process with the
_POSIX_SPAWN_DISABLE_ASLR flag set when
-profis specified.The options parser is smart enough to understand any combination of
-profand-noprof, including alternative spellings like--no_prof.Fixes: #6466
CI: https://ci.nodejs.org/job/node-test-pull-request/2429/