test_runner: restore directory search for --test by bitpshr · Pull Request #64637 · nodejs/node

bitpshr · 2026-07-21T03:18:10Z

Fixes #64555. Passing a directory to node --test (like node --test tests) matched the directory itself as a glob pattern and then tried to run it as a test file, failing with MODULE_NOT_FOUND.

This expands a pattern that resolves to a directory into a search for the default test files inside it, restoring the pre-glob behavior. File paths, real glob patterns, and nonexistent arguments all pass through unchanged.

Note: This isn't Windows-specific despite the report; it reproduces on every platform (on macOS, node@20 searches the directory and passes while node@22 and node@24 both fail).

Passing a directory to `node --test` (e.g. `node --test tests`) matched the directory itself as a glob pattern and then tried to run it as a test file, failing with MODULE_NOT_FOUND. Before glob patterns were supported, a directory argument was searched for test files within it. Expand a pattern that resolves to a directory into a search for the default test files inside it. Despite the report framing this as Windows-only, it reproduces on every platform: it is a plain regression from when directory arguments stopped being searched. Fixes: nodejs#64555 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-07-21T03:18:16Z

Review requested:

@nodejs/test_runner

bitpshr · 2026-07-21T11:17:16Z

Both CI failures look unrelated to this change. test-macOS failed on test-debugger-probe-script-throws.js in the "unusual chars folder" re-run step, and the aarch64 shared-boringssl build failed on test-repl-context.mjs with ERR_INSPECTOR_COMMAND: Inspector error -32000: Promise was collected (the log shows failed 1 out of 10, so it's flaky). This PR only touches test runner directory handling, and its own test passed. A re-run should clear them.

bitpshr · 2026-08-05T15:23:03Z

Just keeping this on the radar. It's been approved for a couple of weeks now, and it's a small test_runner fix (restoring directory arguments to node --test) with a regression test. @MoLow is there anything else needed to get it landed?

codecov · 2026-08-06T20:12:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (6071907) to head (b48ff5b).
⚠️ Report is 501 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #64637   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files         741      741           
  Lines      242076   242095   +19     
  Branches    45550    45552    +2     
=======================================
+ Hits       218199   218219   +20     
+ Misses      15391    15386    -5     
- Partials     8486     8490    +4

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	`94.52% <100.00%> (+0.09%)`	⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bitpshr · 2026-08-17T16:20:44Z

Just keeping this on the radar, it has been approved and author ready for a few weeks now. Is anything blocking it from landing? Happy to rebase if it needs a refresh.

nodejs-github-bot · 2026-08-21T15:26:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76157/

nodejs-github-bot · 2026-08-21T17:05:44Z

Commit Queue failed

- Loading data for nodejs/node/pull/64637
✔  Done loading data for nodejs/node/pull/64637
----------------------------------- PR info ------------------------------------
Title      test_runner: restore directory search for --test (#64637)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     bitpshr:test-runner/dir-arg-search -> nodejs:main
Labels     author ready, needs-ci, commit-queue, test_runner
Commits    1
 - test_runner: restore directory search for --test
Committers 1
 - Paul Bouchon <mail@bitpshr.net>
PR-URL: https://github.com/nodejs/node/pull/64637
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64637
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 21 Jul 2026 03:18:10 GMT
   ✔  Approvals: 1
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/64637#pullrequestreview-4743076856
   ✘  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-08-21T15:26:07Z: https://ci.nodejs.org/job/node-test-pull-request/76157/
- Querying data for job/node-test-pull-request/76157/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/32505631714

nodejs-github-bot · 2026-08-21T18:16:59Z

Commit Queue failed

- Loading data for nodejs/node/pull/64637
✔  Done loading data for nodejs/node/pull/64637
----------------------------------- PR info ------------------------------------
Title      test_runner: restore directory search for --test (#64637)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     bitpshr:test-runner/dir-arg-search -> nodejs:main
Labels     author ready, needs-ci, commit-queue, test_runner
Commits    1
 - test_runner: restore directory search for --test
Committers 1
 - Paul Bouchon <mail@bitpshr.net>
PR-URL: https://github.com/nodejs/node/pull/64637
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64637
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 21 Jul 2026 03:18:10 GMT
   ✔  Approvals: 1
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/64637#pullrequestreview-4743076856
   ✘  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-08-21T17:05:44Z: https://ci.nodejs.org/job/node-test-pull-request/76157/
- Querying data for job/node-test-pull-request/76157/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/32512148725

Passing a directory to `node --test` (e.g. `node --test tests`) matched the directory itself as a glob pattern and then tried to run it as a test file, failing with MODULE_NOT_FOUND. Before glob patterns were supported, a directory argument was searched for test files within it. Expand a pattern that resolves to a directory into a search for the default test files inside it. Despite the report framing this as Windows-only, it reproduces on every platform: it is a plain regression from when directory arguments stopped being searched. Fixes: #64555 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #64637 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

trivikr · 2026-08-21T20:03:59Z

Landed in 838a3e9

Passing a directory to `node --test` (e.g. `node --test tests`) matched the directory itself as a glob pattern and then tried to run it as a test file, failing with MODULE_NOT_FOUND. Before glob patterns were supported, a directory argument was searched for test files within it. Expand a pattern that resolves to a directory into a search for the default test files inside it. Despite the report framing this as Windows-only, it reproduces on every platform: it is a plain regression from when directory arguments stopped being searched. Fixes: #64555 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #64637 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Node 24.x does not search a directory passed to `--test`: it takes the positional argument as a single test file, spawns a child to load it, and the CJS loader fails with Error: Cannot find module '.../harness-accountant/test' code: 'MODULE_NOT_FOUND' reporting one passing and one failing test. Node 20 still searches and Node 26 restored the search (nodejs/node#64637), so the v1.0.0 release's first hosted run went red on exactly one leg of the two-version matrix while the other stayed green - which is why it survived review, and why the author's own Node 26 could not reproduce it. Reproduced on a downloaded Node v24.21.0: the old command gives tests 1 / pass 0 / fail 1, the new one gives tests 87 / pass 87 / fail 0. Node 20.19.5 and Node 26.10.0 both pass with the new one. The command is now identical in the workflow, the `test` script, README (twice) and THREAT.md, so the documentation cannot drift from CI. The workflow carries the reasoning in a comment, because `node --test test/` looks like the tidier form and would re-break the Node 24 leg.

bitpshr mentioned this pull request Jul 21, 2026

test_runner: directory arguments to --test fail with MODULE_NOT_FOUND on Windows (regression since v20) #64555

Closed

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jul 21, 2026

MoLow approved these changes Jul 21, 2026

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 6, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 6, 2026

This comment was marked as outdated.

Sign in to view

coderabbitai Bot mentioned this pull request Aug 17, 2026

refactor: isolate Codeforces integration mc-cari/codeforces-live-standings#29

Merged

coderabbitai Bot mentioned this pull request Aug 18, 2026

feat: JavaScript 코딩테스트 4차 구현 bam090/BAM.dev#3

Merged

8 of 12 tasks

trivikr added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 21, 2026

This comment was marked as outdated.

Sign in to view

trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 21, 2026

richardlau added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 21, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 21, 2026

trivikr removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Aug 21, 2026

trivikr closed this Aug 21, 2026

This was referenced Aug 23, 2026

✨ [FEAT] 행사 상세·광고 결제 및 Groq AI 고도화 half-fifty/eventoday#117

Merged

cleanup: restructure Windows runtime and validation amanthanvi/noctty#177

Merged

github-actions Bot mentioned this pull request Aug 25, 2026

2026-08-26, Version 26.8.0 (Current) #65551

Merged

Navigation Menu

Uh oh!

test_runner: restore directory search for --test - #64637

test_runner: restore directory search for --test#64637
bitpshr wants to merge 1 commit into
nodejs:mainfrom
bitpshr:test-runner/dir-arg-search

bitpshr commented Jul 21, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Jul 21, 2026

Uh oh!

bitpshr commented Jul 21, 2026

Uh oh!

bitpshr commented Aug 5, 2026

Uh oh!

codecov Bot commented Aug 6, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

bitpshr commented Aug 17, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Aug 21, 2026

Uh oh!

nodejs-github-bot commented Aug 21, 2026

Uh oh!

nodejs-github-bot commented Aug 21, 2026

Uh oh!

trivikr commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

bitpshr commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 21, 2026

Uh oh!

bitpshr commented Jul 21, 2026

Uh oh!

bitpshr commented Aug 5, 2026

Uh oh!

codecov Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

bitpshr commented Aug 17, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Aug 21, 2026

Uh oh!

nodejs-github-bot commented Aug 21, 2026

Uh oh!

nodejs-github-bot commented Aug 21, 2026

Uh oh!

trivikr commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bitpshr commented Jul 21, 2026 •

edited

Loading

codecov Bot commented Aug 6, 2026 •

edited

Loading