build: run lint jobs even if tests fail

[Trott]

• Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
  this change (including linting)?
• Is the commit message formatted according to [CONTRIBUTING.md][0]?
• If this change fixes a bug (or a performance problem), is a regression
  test (or a benchmark) included?
• Is a documentation update included (if this change modifies
  existing APIs, or introduces new ones)?

Description of change

Reviewable version of Option 3 from #5607. If tests fail, lint still runs. Recipe exits with error if any tests or lint tasks don't run without incident.

This is a proof-of-concept for a small change but the small change has potentially enormous consequences. So, you know, don't merge casually. Added in progress label to try to make that clear.

[Trott]

CI, although i don't think this make-task is run on CI, but you know, just in case: https://ci.nodejs.org/job/node-test-commit/2494/

[Fishrock123]

This looks fine to me, maybe @nodejs/ctc or @nodejs/build could comment?

[orangemocha]

The code change LGTM per se, though I have not reviewed the merits of why this should be done (#5607)

[jbergstroem]

I personally don't like this style and would prefer splitting them but can understand the rationale. I'm -0.

[ofrobots]

Are these spaces? Need to be a tab.

[Trott]

Whoops! Rebased and changed to tabs.

[ofrobots]

I would also prefer if the lint check was split out from the test and added as a prerequisite. I personally don't care about running lint while I am hacking at stuff, so I would like to be able to run the tests without the lint; it would be good if there was a target I could use to do that.

[Trott]

This doesn't seem like it's going to get consensus any time soon so I'm going to go ahead and close it. In theory, I do like the idea of separating the lint job from the test job entirely. In practice, I think people will just forget to lint and then we won't catch stuff until CI runs. So I'm not inclined to make that change myself. (But I wouldn't stop someone else who wanted to make it and could get consensus on it.)

[jbergstroem]

@Trott we could always replace all references to make test with make lint test?