Skip to content

test: add test cases for getDirents and getDirent function #54634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sendoru wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: add test cases for getDirents and getDirent function #54634

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31119e1
test: add test cases for getDirents and getDirent function
sendoru Sep 25, 2024
6baae35
test: linted code
sendoru Sep 25, 2024
cf7849f
test: apply suggestions of RedYetiDev
sendoru Sep 25, 2024
885bc55
test: simplify RegEx for error code matching
sendoru Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion test/parallel/test-fs-utils-get-dirents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@ const common = require('../common');
const { getDirents, getDirent } = require('internal/fs/utils');
const assert = require('assert');
const { internalBinding } = require('internal/test/binding');
const { UV_DIRENT_UNKNOWN } = internalBinding('constants').fs;
const { UV_DIRENT_UNKNOWN, UV_DIRENT_FILE } = internalBinding('constants').fs;
const fs = require('fs');
const { resolve } = require('path');

const tmpdir = require('../common/tmpdir');
const filename = 'foo';
const nonExistentPath = resolve(tmpdir.path, 'does-not-exist');

{
// setup
Expand Down Expand Up @@ -65,6 +67,18 @@ const filename = 'foo';
},
));
}
{
// Intentional error in lstat
getDirents(
Buffer.from(nonExistentPath),
[[Buffer.from(filename)], [UV_DIRENT_UNKNOWN]],
common.mustCall((err) => {
assert.match(
err.code, /ENOTDIR|ENOENT/
);
},
));
}
// getDirent
{
// string + string
Expand Down Expand Up @@ -125,3 +139,28 @@ const filename = 'foo';
},
));
}
{
// When type != UV_DIRENT_UNKNOWN
getDirent(
tmpdir.path,
filename,
UV_DIRENT_FILE,
common.mustCall((err, dirent) => {
assert.strictEqual(err, null);
assert.strictEqual(dirent.name, filename);
},
));
}
{
// Intentional error in lstat
getDirent(
nonExistentPath,
filename,
UV_DIRENT_UNKNOWN,
common.mustCall((err) => {
assert.match(
err.code, /ENOTDIR|ENOENT/
);
},
));
}