Skip to content

fix: Invalid test outputs cause of new line chars in test name fixed #45552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scuro-dev wants to merge 1 commit into from
Closed

fix: Invalid test outputs cause of new line chars in test name fixed #45552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/internal/test_runner/tap_stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,12 @@ class TapStream extends Readable {
// In certain places, # and \ need to be escaped as \# and \\.
function tapEscape(input) {
return StringPrototypeReplaceAll(
StringPrototypeReplaceAll(input, '\\', '\\\\'), '#', '\\#'
);
StringPrototypeReplaceAll(

@anonrig anonrig Nov 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the linting issues?

@Trott Trott Nov 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running make lint-js-fix (or vcbuild lint-js-fix on Windows) should fix most of these lint issues automatically.

StringPrototypeReplaceAll(input, '\\', '\\\\'),
'#', '\\#'
),
'\n', '\\n'
);
}

function jsToYaml(indent, name, value) {
Expand Down