Skip to content

src: do not ignore return value of BIO_reset - #42103

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:src-dont-ignore-bio-reset-return
Feb 27, 2022
Merged

src: do not ignore return value of BIO_reset#42103
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:src-dont-ignore-bio-reset-return

Conversation

@tniessen

@tniessen tniessen commented Feb 24, 2022

Copy link
Copy Markdown
Member

The USE macro indicates that a value is intentionally ignored. Instead, CHECK that the function succeeds.

These are always in-memory BIOs so we don't expect BIO_reset to ever fail. Either way, we should CHECK that assumption.

Tobias Nießen
src: do not ignore return value of BIO_reset
9d69bd7 
The USE macro indicates that a value is intentionally ignored. Instead,
CHECK that the function succeeds.
@nodejs-github-bot

ghost commented Feb 24, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Feb 24, 2022
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 24, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 24, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

ghost commented Feb 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42760/

@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 24, 2022
@tniessen tniessen self-assigned this Feb 25, 2022
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 27, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 1ce42ec into nodejs:master Feb 27, 2022
@nodejs-github-bot

ghost commented Feb 27, 2022

Copy link
Copy Markdown
Collaborator

Landed in 1ce42ec

@sxa sxa mentioned this pull request Mar 8, 2022
Merged
@danielleadams danielleadams mentioned this pull request Apr 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

@tniessen tniessen

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen @nodejs-github-bot @panva @lpinca @richardlau @RaisinTen