Skip to content

test failures without openssl-cli #9509

Closed
Closed
test failures without openssl-cli#9509
Labels
good first issueIssues that are suitable for first-time contributors.opensslIssues and PRs related to the OpenSSL dependency.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@shigeki
shigeki
opened on Nov 8, 2016
  • Version: v8.0.0-pre
  • Platform: all
  • Subsystem: test

When openssl-cli is not found, several tests are failed due to missing its check.

$ rm out/Release/openssl-cli
$ python tools/test.py --mode=release parallel -J
(snip)
[00:22|% 100|+ 1166|-   4]: Done

This issue is reserved to be fixed in the course of Code and Learn in Node Fest Tokyo 2016.

Ref: nodejs/code-and-learn#58

Activity

  1. shigeki
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    good first issueIssues that are suitable for first-time contributors.
    on Nov 8, 2016

  2. bnoordhuis commented on Nov 8, 2016

    @bnoordhuis
    bnoordhuis
    on Nov 8, 2016
    Member

    Is that something that really needs fixing though? It only breaks when you actively sabotage it.

  3. shigeki commented on Nov 8, 2016

    @shigeki
    shigeki
    on Nov 8, 2016
    ContributorAuthor

    I think the tests would fail if Node is built with shared openssl library in which openssl-cli does not exist.

  4. bnoordhuis commented on Nov 8, 2016

    @bnoordhuis
    bnoordhuis
    on Nov 8, 2016
    Member

    I understand now. That's right, it won't get built. I'd probably make openssl-cli build unconditionally rather than trying to fix up the tests.

  5. shigeki commented on Nov 8, 2016

    @shigeki
    shigeki
    on Nov 8, 2016
    ContributorAuthor

    The common.opensslCli looks for external openssl command when shared library is used so that the test failure would happened in very limited case, as only libraries are installed or it does not have a path to the command.

    So I think it is good to check via common.opensslCli such as other tests do now rather than to build openssl-cli even in shared library.

  6. mscdex
    added
    opensslIssues and PRs related to the OpenSSL dependency.
    on Nov 8, 2016

  7. shigeki commented on Nov 18, 2016

    @shigeki
    shigeki
    on Nov 18, 2016
    ContributorAuthor

    No one worked in this issue so it is open to everyone.

  8. sotayamashita commented on Jan 25, 2017

    @sotayamashita
    sotayamashita
    on Jan 25, 2017
    Contributor

    I would like to work on this one. 💪
    https://github.com/sotayamashita/node/tree/feature/test-openssl-cli

  9. sotayamashita commented on Feb 1, 2017

    @sotayamashita
    sotayamashita
    on Feb 1, 2017
    Contributor

    @shigeki I would like to ask a question. How to generate common/ which is required in test code.
    Thanks in advance.

    I miss understood and I figure it out now 😃

  10. sotayamashita commented on Feb 14, 2017

    @sotayamashita
    sotayamashita
    on Feb 14, 2017
    Contributor

    Landed in 5ffb7d7.

    @shigeki Could you close this issue ?

  11. shigeki commented on Feb 14, 2017

    @shigeki
    shigeki
    on Feb 14, 2017
    ContributorAuthor

    @sotayamashita Thanks.

  12. shigeki
    closed this as completedon Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are suitable for first-time contributors.opensslIssues and PRs related to the OpenSSL dependency.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions