You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Mention case-insensitivity in process.env docs #9157
It might also be good to add tests for this behaviour to detect platform differences or keep us from accidentally changing anything here.
Would you be interested in writing a pull request to add this yourself? The files to edit should be doc/api/process.md and/or test/parallel/test-process-env.js.
@addaleax I'm not quite sure how to properly test this behavior, as the behavior would likely change depending on which OS you're running the test on. If you have any suggestions, please let me know and I'd be happy to write the test as well.
@addaleax Is there also a guide for building Node on Windows? Because I'm getting a bunch of linker errors when trying to vcbuild test nosign with Visual Studio 2015.
So does this mean that process.env is guaranteed to have case-insensitive keys on Windows, even going back to v4? I've hunted in the past for documentation, couldn't find anything, so I just assumed that was the case. Thanks.
Activity
addaleax commentedon Oct 18, 2016
It might also be good to add tests for this behaviour to detect platform differences or keep us from accidentally changing anything here.
Would you be interested in writing a pull request to add this yourself? The files to edit should be
doc/api/process.mdand/ortest/parallel/test-process-env.js.oliversalzburg commentedon Oct 18, 2016
@addaleax I'm not quite sure how to properly test this behavior, as the behavior would likely change depending on which OS you're running the test on. If you have any suggestions, please let me know and I'd be happy to write the test as well.
addaleax commentedon Oct 18, 2016
@oliversalzburg There’s https://github.com/nodejs/node/blob/master/doc/guides/writing_tests.md for generic “How to write a test” things, and you can check for
common.isWindowsin tests to see whether the test is running on Windows or not. Ideally, you’d check that other OS show the opposite behaviour, to make sure that it’s really only Windows that does this.oliversalzburg commentedon Oct 18, 2016
@addaleax Ah, sounds good. Thanks for the help :)
oliversalzburg commentedon Oct 18, 2016
@addaleax Is there also a guide for building Node on Windows? Because I'm getting a bunch of linker errors when trying to
vcbuild test nosignwith Visual Studio 2015.addaleax commentedon Oct 18, 2016
I am afraid I can only ask @nodejs/platform-windows, but it might help if you have the errors somewhere in a gist or something
oliversalzburg commentedon Oct 18, 2016
Alright, I'll put the information into the PR. Thanks again
joaocgreis commentedon Oct 19, 2016
For reference, guide for building on Windows: https://github.com/nodejs/node/blob/master/BUILDING.md#windows
nfischer commentedon Oct 20, 2016
So does this mean that
process.envis guaranteed to have case-insensitive keys on Windows, even going back to v4? I've hunted in the past for documentation, couldn't find anything, so I just assumed that was the case. Thanks.4 remaining items
test: case sensitivity of env variables
doc: mention case-insensitive env on windows
test: case sensitivity of env variables
test: case sensitivity of env variables
doc: mention case-insensitive env on windows
test: case sensitivity of env variables
doc: mention case-insensitive env on windows
fix(windows): remove dead PYTHONSTARTUP code, fix PATH case sensitivity
fix(windows): resolve pywin32 DLL loading failure on Python 3.8+ (#1244)
fix(windows): resolve pywin32 DLL loading failure on Python 3.8+ (#1244)
fix(windows): resolve pywin32 DLL loading failure on Python 3.8+ (#1244)
doc: mention case-insensitive env on windows
fix(windows): resolve pywin32 DLL loading failure on Python 3.8+ (And…
fix(windows): resolve pywin32 DLL loading failure on Python 3.8+ (And…
fix(windows): resolve pywin32 DLL loading failure on Python 3.8+ (And…