Repository navigation
6.8.1 fails to fix const error for shared-zlib older than 1.2.5 #9110
Description
Activity
/cc @bradleythughes ?
We could simply drop the ZLIB_CONST changes and const_cast PROTOCOL_JSON. I hate the thought of adding ugly hacks for obsolete software but it's too small of an issue to take a principal stand.
Reacted by jacob kiliI was going to suggest the same thing. I'll see if I can get a PR up later this evening.
- added a commit that references this issue
on Oct 18, 2016 - added a commit that references this issue
on Oct 18, 2016 Closing, fix released in v6.9.0.
ZLIB_CONSTwas added in zlib-1.2.5.2 (see http://zlib.net/ChangeLog.txt)Redhat Linux 6.8 is still on zlib-1.2.3, and as such does not have the
ZLIB_CONSTfeature.Even with the change in #9077, compiling nodejs wih --shared-zlib fails on this system, with the same error as 6.8.0
In versions of zlib prior to 1.2.5.2, strm.next_in will never be const