Skip to content

[stream] Standardize a way for writable streams to do work after all data has been consumed. #821

Description

@markstos

There was a lot of discussion about this pre-fork:

nodejs/node-v0.x-archive#7631
nodejs/node-v0.x-archive#7348

Note that while waiting for an upstreaming fix, @TomFrost implemented a workaround that is published on npmjs.org:

https://www.npmjs.com/package/flushwritable

Perhaps it will be helpful in considering the issue.

Activity

  1. Fishrock123 commented on Feb 12, 2015

    @Fishrock123
    Contributor

    https://github.com/iojs/readable-stream may be a better place to discuss this. :)

  2. markstos commented on Feb 12, 2015

    @markstos
    Author

    @Fishrock123 I opened an issue in the readable-stream queue as you suggested:

    nodejs/readable-stream#112

    If this is the wrong place for stream issues now, this can be closed.

  3. vkurchatkin commented on Feb 12, 2015

    @vkurchatkin
    Contributor

    I'm +1. Also want _open and _close hooks for all streams

  4. tellnes commented on Feb 12, 2015

    @tellnes
    Contributor

    +1 from me also.

    @vkurchatkin What do you mean by _open and _close. Are you referring to fs streams which does fs.open?

  5. vkurchatkin commented on Feb 12, 2015

    @vkurchatkin
    Contributor

    Yeah, default open, close and destroy implementations which call hooks. Also auto-open, like in fs

  6. chrisdickinson commented on Feb 12, 2015

    @chrisdickinson
    Contributor

    Redirecting conversation to the readable-stream issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    streamIssues and PRs related to Node.js streams.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions