Repository navigation
v8 inspector build failure: File name too long #7959
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.
Description
Activity
It's a gyp issue. Cheap hack to work around it:
diff --git a/tools/gyp/pylib/gyp/generator/make.py b/tools/gyp/pylib/gyp/generator/make.py index a81f639..47e841e 100644 --- a/tools/gyp/pylib/gyp/generator/make.py +++ b/tools/gyp/pylib/gyp/generator/make.py @@ -21,6 +21,7 @@ # toplevel Makefile. It may make sense to generate some .mk files on # the side to keep the the files readable. +import hashlib import os import re import sys @@ -873,6 +874,7 @@ $(obj).$(TOOLSET)/$(TARGET)/%%.o: $(obj)/%%%s FORCE_DO_CMD for action in actions: name = StringToMakefileVariable('%s_%s' % (self.qualified_target, action['action_name'])) + name = hashlib.sha1(name).hexdigest() self.WriteLn('### Rules for action "%s":' % action['action_name']) inputs = action['inputs'] outputs = action['outputs']
Not really a proper fix but it demonstrates where the issue lies.
- addedbuildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.
on Aug 3, 2016 See also #7510… would pulling in addaleax@4747d1b be acceptable as floating a patch on gyp?
Great minds really do seem to think alike... In light of Google's lack of interest in maintaining gyp, I think floating a patch is acceptable.
Reacted by James M SnellReacted by Gibson FahnestockPR: #7963
- added a commit that references this issue
on Aug 3, 2016 - added a commit that references this issue
on Aug 8, 2016 - added a commit that references this issue
on Aug 10, 2016 - added a commit that references this issue
on Sep 30, 2016 - added a commit that references this issue
on Oct 8, 2016 - added a commit that references this issue
on Oct 18, 2016 - added a commit that references this issue
on Oct 26, 2016 - added 2 commits that reference this issue
on Aug 9, 2018
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.
I'm assuming this is because the file name is 258 characters long, as the name contains the full directory path. This can be worked around with custom Jenkins workspaces, but the file name is 168 chars without the directory structure anyway.