Skip to content

Add missing collaborators to README #778

Closed
Closed
Add missing collaborators to README#778
Labels
docIssues and PRs related to Node.js documentation.

Description

@rvagg
rvagg
opened on Feb 10, 2015

We're missing some new collaborators from the README, would the following people mind submitting a PR to get their details on there please?

It's a helpful part of the onboarding process for a couple of reasons:

  1. practice & a safe way to check that you're on the right wavelength re git workflow
  2. demonstrate that the project really is open
  3. provide additional kudos to those putting in the hard work here

Activity

  1. shigeki commented on Feb 10, 2015

    @shigeki
    shigeki
    on Feb 10, 2015
    Contributor

    @rvagg I don't mind submitting PR but I'd like to have a sample what to write or see what others write.

  2. vkurchatkin commented on Feb 10, 2015

    @vkurchatkin
    vkurchatkin
    on Feb 10, 2015
    Contributor

    @shigeki something like this 96597bc

  3. rvagg commented on Feb 10, 2015

    @rvagg
    rvagg
    on Feb 10, 2015
    MemberAuthor

    git log -- README.md yields the interesting results and points towards recent PRs:

    See the merged commits for the process of merging them once you get a "lgtm" or two. If you need any further help please reach out for help and people will jump to your rescue.

  4. Fishrock123
    added
    docIssues and PRs related to Node.js documentation.
    on Feb 10, 2015

  5. shigeki commented on Feb 10, 2015

    @shigeki
    shigeki
    on Feb 10, 2015
    Contributor

    @vkurchatkin @rvagg Thanks for advice. I thought I need to write some kind of vitae somewhere :-) It's a simple PR procedure. I will do it right now.

  6. shigeki
    added 2 commits that reference this issue on Feb 10, 2015

    doc: add shigeki as collaborator

    1d160fe

    doc: add shigeki as collaborator

    aea9b89

  7. sam-github commented on Feb 11, 2015

    @sam-github
    sam-github
    on Feb 11, 2015
    Contributor

    Sorry, @rvagg @chrisdickinson I've been distracted by node summit!

  8. cjihrig commented on Feb 15, 2015

    @cjihrig
    cjihrig
    on Feb 15, 2015
    Contributor

    Looks like everyone mentioned here has been added.

  9. cjihrig
    closed this as completedon Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions