Repository navigation
Clarify "fs.readFile", "fs.appendFile", "fs.writeFile" documentation regarding closing #7560
Description
Activity
Emmm, so what is left before this change can be pulled?..
I have two LGTMs on the pull request. If current blocker is the latest comment from the fourth reviewer, could I get a second opinion on that? Currently I have doubts about whether the suggested change should be made, but if someone else agrees it would be for the best, I'll make it.
@kibertoad For one, it’s a bit confusing to see comments that are only about the PR to pop up on the thread for the corresponding issue. ;)
@kibertoad I think the occasional “ping”/“bump”/… comment on a PR which hasn’t received feedback for a couple of days is pretty much okay.
- added a commit that references this issue
on Aug 8, 2016 - added a commit that references this issue
on Aug 10, 2016
"https://nodejs.org/api/fs.html#fs_fs_readfile_file_options_callback" states that
This is confusing for new users, because it implies that opened file should always be manually closed, leading to questions like this - http://stackoverflow.com/questions/21523890/close-file-after-fs-readfile-nulling
It should be mentioned that if "file" is specified as a filename, it will, indeed, be closed automatically.