Repository navigation
[tools] update cpplint.py #7444
Description
Activity
I'd be up for taking a dig into it. @trevnorris do we have any idea how many patches there are?
$ git log --pretty=oneline tools/cpplint.py bb33c28e2141a1eabdff753e6717f5aea5866146 tools: disable readability/function cpplint rule 3eff42bbca531873905ef4478e8d6ec9a7485d3a tools: reduce verbosity of cpplint 813e73e1f5fa0cfa357164138e3d52acab508718 tools: list missing whitespace/if-one-line cpplint 7b4516356a1c72b08d9c4eb7ad1d25a1804cbe62 tools: add tap output to cpplint a493dab2e72d19ddd226cd2094463ddb2354af06 cpplint: make it possible to run outside git repo 7861ff47285084604963a9f269b6062a23acd8a2 test: create test-ci, modify test-all, fix cpplint 2bc30f239be3e56d642eda38df98c656d55b4d86 cpplint: disallow if one-liners 7063c59b97fa4f365f9e5ec1f563235ede4104db cpplint: disallow comma-first in C++ 98c54246c208698ded4c88abd37bb75b926d687d tools: cpplint: fix NOLINT(build/include_order) 847c6d980c83274b6c37e29a07d19a696435588b tools: cpplint: fix up build/include_order rule 3c6b5d5df1e445d080737e435675e11b102f0126 cpplint: make lint rules closer to node's source 3058f08e645bca41ee0f281ed83a697be1e3c8c4 tools: remove unnecessary cpplint rules ac58d3a6653425cb625684bc6ffc38ecc89646c8 Import cpplint.pySeems like all of these except for the first one are from us?
I'll have a stab at this.
- Reacted by Myles Borins, Trevor Norris and Sakthipriyan Vairamani
Yey!
The file
tools/cpplint.pyneeds to be updated with the latest (https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py). Reason is because some header information has changed that's causing lint errors for c++11 specific code. Specifically thatstd::swap()used to be in<algorithm>but since c++11 is now in<utility>.The file will need to be updated, and all previous patches will need to be reapplied. The later is the difficult part, and my python isn't up to snuff to deal with them.