Skip to content

Error ONLY when running babel task on arm64 node v4.4.6 #7417

Closed
Closed
Error ONLY when running babel task on arm64 node v4.4.6#7417
Assignees
MylesBorins
Labels
armIssues and PRs related to the ARM architecture.confirmed-bugIssues and PRs for confirmed bugs.v8 engineIssues and PRs related to the V8 dependency.

Description

@TomFreudenberg
TomFreudenberg
opened on Jun 25, 2016

Hi, I have reported an error on the babel issue tracker at https://phabricator.babeljs.io/T7457

but it might also be, that this is an issue on node v4?

The issue described does ONLY occur an the arm64 architecture (I am also using the linoaro dev cluster).

In a short:

running:

mkdir -p /tmp/babel-test

cd /tmp/babel-test

npm install babel-cli babel-preset-es2015 --save-dev

./node_modules/.bin/babel ./node_modules/babel-polyfill/dist/polyfill.js -d lib --presets es2015 --no-babelrc

will return

[BABEL] Note: The code generator has deoptimised the styling of "./node_modules/babel-polyfill/dist/polyfill.js" as it exceeds the max of "100KB".
TypeError: ./node_modules/babel-polyfill/dist/polyfill.js: Cannot read property 'compact' of undefined
at Function.space (/tmp/babel-test/node_modules/babel-generator/lib/buffer.js:139:20)
at Function.ObjectExpression (/tmp/babel-test/node_modules/babel-generator/lib/generators/types.js:62:10)
at /tmp/babel-test/node_modules/babel-generator/lib/printer.js:113:24
at Generator.withSource (/tmp/babel-test/node_modules/babel-generator/lib/buffer.js:293:39)
at Generator.print (/tmp/babel-test/node_modules/babel-generator/lib/printer.js:112:10)
at Generator.printJoin (/tmp/babel-test/node_modules/babel-generator/lib/printer.js:197:12)
at Generator.printList (/tmp/babel-test/node_modules/babel-generator/lib/printer.js:261:17)
at Generator.CallExpression (/tmp/babel-test/node_modules/babel-generator/lib/generators/expressions.js:144:8)
at /tmp/babel-test/node_modules/babel-generator/lib/printer.js:113:24
at Generator.withSource (/tmp/babel-test/node_modules/babel-generator/lib/buffer.js:293:39)

If I use node v6.2.2 arm64 and run the same command, the result is:

[BABEL] Note: The code generator has deoptimised the styling of "./node_modules/babel-polyfill/dist/polyfill.js" as it exceeds the max of "100KB".
./node_modules/babel-polyfill/dist/polyfill.js -> lib/node_modules/babel-polyfill/dist/polyfill.js

Seems to be a kind of memory leak ?

Activity

  1. mscdex commented on Jun 25, 2016

    @mscdex
    mscdex
    on Jun 25, 2016
    Contributor

    This looks more like a babel bug than a node bug. Perhaps one of their userland modules does some sort of node version checking or makes some kind of wrong assumption?

  2. mscdex
    added
    v4.x
    on Jun 25, 2016

  3. TomFreudenberg commented on Jun 25, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 25, 2016
    Author

    Hi Brian ( @mscdex )

    I have no clue currently, so thats why I posted in both trackers. Its a pitty, we got nearly everything running on the arm64 and its just the unpacking what is missing now ;-)

    Sometimes I hate the jobs ;-)

    Thanks for your feedback, hopefully someone from babel tracker will answer too

    Tom

  4. loganfsmyth commented on Jun 26, 2016

    @loganfsmyth
    loganfsmyth
    on Jun 26, 2016
    Contributor

    Hey @mscdex, see my response here: https://phabricator.babeljs.io/T7457#79767

    There are a bunch of things about this error that make me think it was likely a V8 issue that's been fixed between 4.4.6 and 6.2.2. Primarily, this.format should always be an object, and if it weren't, several functions called before the one in question would have triggered the same error were that the case, combined with the inability to reproduced on x86 and Node 6 ARM64.

  5. TomFreudenberg commented on Jun 26, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 26, 2016
    Author

    Hi Brian, Logan @mscdex @loganfsmyth

    if necessary, I can give you access to my linaro development cluster or help you to get an account yourself.

    Would be great if this could be get fixed, because meteor will not move soon to node 6.

    P.S.: I will run a test on latest node 5 as well - an post result here.

  6. TomFreudenberg commented on Jun 26, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 26, 2016
    Author

    Hi, as expected - it seems to be just an error on the 4.4.6. Doing the same check with node_ v5.12.0-arm64

    Just to have this test also with node v5, result is correct working:

    PATH=$PATH:/tmp/node5/bin ./node_modules/.bin/babel ./node_modules/babel-polyfill/dist/polyfill.js -d lib --presets es2015 --no-babelrc

    BABEL] Note: The code generator has deoptimised the styling of "./node_modules/babel-polyfill/dist/polyfill.js" as it exceeds the max of "100KB".
    ./node_modules/babel-polyfill/dist/polyfill.js -> lib/node_modules/babel-polyfill/dist/polyfill.js

    This works also fine

  7. MylesBorins commented on Jun 26, 2016

    @MylesBorins
    MylesBorins
    on Jun 26, 2016
    Contributor

    Are older versions of v4 working fine?
    On Jun 26, 2016 1:17 PM, "Tom Freudenberg" notifications@github.com wrote:

    Hi, as expected - it seems to be just an error on the 4.4.6. Doing the
    same check with node_ v5.12.0-arm64

    Just to have this test also with node v5, result is correct working:

    PATH=$PATH:/tmp/node5/bin ./node_modules/.bin/babel ./node_modules/babel-polyfill/dist/polyfill.js -d lib --presets es2015 --no-babelrc

    BABEL] Note: The code generator has deoptimised the styling of
    "./node_modules/babel-polyfill/dist/polyfill.js" as it exceeds the max of
    "100KB".
    ./node_modules/babel-polyfill/dist/polyfill.js ->
    lib/node_modules/babel-polyfill/dist/polyfill.js

    This works also fine

    —
    You are receiving this because you are subscribed to this thread.
    Reply to this email directly, view it on GitHub
    #7417 (comment), or mute
    the thread
    https://github.com/notifications/unsubscribe/AAecV7iLOI08zhnu3nGT7ZAH-OzECAYIks5qPt5kgaJpZM4I-WUm
    .

  8. TomFreudenberg commented on Jun 26, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 26, 2016
    Author

    I had currently the same idea and will test. Let me run some and I give feedback

  9. TomFreudenberg commented on Jun 26, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 26, 2016
    Author

    @mscdex @loganfsmyth @thealphanerd

    Ok guys, got it

    node-v5.0.0-arm64 IS NOT WORKING
    node-v5.1.0-arm64 IS OK

  10. MylesBorins commented on Jun 26, 2016

    @MylesBorins
    MylesBorins
    on Jun 26, 2016 via email
    Contributor

  11. TomFreudenberg commented on Jun 26, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 26, 2016
    Author

    Yes, I know but v4 doesnt work at all, otherwise I have to check for v6

  12. TomFreudenberg commented on Jun 26, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 26, 2016
    Author

    @thealphanerd But can't we use the diff between v5.0.0 and v5.1.0 to see what changes might repair that issue?

  13. MylesBorins commented on Jun 26, 2016

    @MylesBorins
    MylesBorins
    on Jun 26, 2016 via email
    Contributor

  14. TomFreudenberg commented on Jun 26, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 26, 2016
    Author

    Thanks Myles @thealphanerd

    I will check the v6 branches to see if there is also one not working

  15. TomFreudenberg commented on Jun 26, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 26, 2016
    Author

    Already node-v6.0.0-arm64 is working, but I guess this is clear, because the v6 branch was created sometimes out of v5 branch. In case that it was fixed in this early v5.1.0 it wasn't propably never an issue in v6.x.x

    So would be great if you could catch it.

    Tom

  16. 14 remaining items

  17. mscdex
    added
    armIssues and PRs related to the ARM architecture.
    confirmed-bugIssues and PRs for confirmed bugs.
    on Jun 26, 2016

  18. MylesBorins commented on Jun 28, 2016

    @MylesBorins
    MylesBorins
    on Jun 28, 2016
    Contributor

    @TomFreudenberg I'm working on getting this in for today's release, but testing has proven a bit more difficult than expected. I'll update in a couple hours

  19. TomFreudenberg commented on Jun 28, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 28, 2016
    Author

    @thealphanerd Myles - Thanks a lot for your support!

  20. MylesBorins commented on Jun 28, 2016

    @MylesBorins
    MylesBorins
    on Jun 28, 2016
    Contributor

    @TomFreudenberg adding to the release!

  21. MylesBorins
    closed this as completedon Jun 28, 2016
  22. MylesBorins
    added a commit that references this issue on Jun 28, 2016

    deps: backport 102e3e87e7 from V8 upstream

    49921e8

  23. TomFreudenberg commented on Jun 29, 2016

    @TomFreudenberg
    TomFreudenberg
    on Jun 29, 2016
    Author

    Hi Myels ( @thealphanerd )

    Thanks for backport, I can confirm that 4.4.7 is now working an my arm64 system

  24. TomFreudenberg
    added a commit that references this issue on Jun 29, 2016

    Upgrade Node to 4.4.6.

    d02446e
  25. gibfahn
    added a commit that references this issue on Jun 29, 2016

    deps/v8z: backport 102e3e87e7 from V8 upstream

    9fe6a3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

armIssues and PRs related to the ARM architecture.confirmed-bugIssues and PRs for confirmed bugs.v8 engineIssues and PRs related to the V8 dependency.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions