Repository navigation
Windows. Incorrect Module.id with mounted network disk #7294
Description
Activity
Yes, with
--preserve-symlinksit works correctly/cc @orangemocha
I found similar problem with
__filenameand__dirname.
node v6.1.0 (and previous):V:\scope\main.js
node v6.2.0 (and v6.2.1):\\CASTOR\scope\main.jsShould I write a new issue for this?
b488b19 is responsible for this - it changed how
fs.realpathworks. It landed in v6.At the same time change to how modules filenames are resolved was introduced in de1dc0a. It switched from
fs.realpathtopath.resolve. Those two changes together made module filenames resolve as before realpath implementation change.Now 5d38d54 put change from
fs.realpathtopath.resolvebehind--preserve-symlinksswitch. And so, instead of having this issue with v6.0, withfs.realpathchange, we have it now. It is just another effect offs.realpathchange which is documented as breaking.I don't know if we should fix this. Old
realpathimplementation on Windows didn't check if the drive itself is a "symlink" - mapped network share or effect of callingsubst. IMHO current implementation is correct. If needed, one can use--preserve-symlinksto make modules file name resolve as they used to before. Alternatively, one can userequire.resolveto get the filename used as keys torequire.cache.Of course, we could also try to fix this. For Windows, we could make
requirefall back to oldrealpathimplementation if new one gives filename on different drive or on a network share. The question is, should we do this?I wrote this module (
t.js):console.log( "__filename: " + __filename + "\r\n" + "__dirname: " + __dirname + "\r\n" + "path.resolve(): " + require("path").resolve() + "\r\n" + "module.id: " + module.id + "\r\n" + "module.filename: " + module.filename );
Run node from
V:\Work\IDEA\projects\efrond\nas\~mount from\\CASTOR-VSRV\Development\Work\IDEA\projects\efrond\nas\~Output
node v5.9.1:__filename: V:\Work\IDEA\projects\efrond\nas\~\t.js __dirname: V:\Work\IDEA\projects\efrond\nas\~ path.resolve(): V:\Work\IDEA\projects\efrond\nas\~ module.id: V:\Work\IDEA\projects\efrond\nas\~\t.js module.filename: V:\Work\IDEA\projects\efrond\nas\~\t.jsnode v6.0.0:
__filename: V:\Work\IDEA\projects\efrond\nas\~\t.js __dirname: V:\Work\IDEA\projects\efrond\nas\~ path.resolve(): V:\Work\IDEA\projects\efrond\nas\~ module.id: V:\Work\IDEA\projects\efrond\nas\~\t.js module.filename: V:\Work\IDEA\projects\efrond\nas\~\t.jsnode v6.2.1:
__filename: \\CASTOR-VSRV\Development\Work\IDEA\projects\efrond\nas\~\t.js __dirname: \\CASTOR-VSRV\Development\Work\IDEA\projects\efrond\nas\~ path.resolve(): V:\Work\IDEA\projects\efrond\nas\~ module.id: \\CASTOR-VSRV\Development\Work\IDEA\projects\efrond\nas\~\t.js module.filename: \\CASTOR-VSRV\Development\Work\IDEA\projects\efrond\nas\~\t.jsnode v6.2.1 --preserve-symlinks:
__filename: V:\Work\IDEA\projects\efrond\nas\~\t.js __dirname: V:\Work\IDEA\projects\efrond\nas\~ path.resolve(): V:\Work\IDEA\projects\efrond\nas\~ module.id: V:\Work\IDEA\projects\efrond\nas\~\t.js module.filename: V:\Work\IDEA\projects\efrond\nas\~\t.jsI do not think it's ok.
Information about the module becomes grease, moreover, it is not obvious.Reacted by Alastair TaftMy situation is even worse, if possible. I'm using Visual Studio Code to develop and debug node projects.
I frequently switch project, so to simplify my workflow I usesubstto make the root of the project act like a disk drive: this makes path shorter (with the side effect of reducing the Windows long path problem) and allows me to quickly change project simply by typing the drive letter.
I recently upgraded to node v6.3.0 and I can't set breakpoint in VS Code anymore, because the modules are loaded with their 'real' path instead of thesubstituted one.
--preserve-symlinksdoesn't resolve the situation: the main file loading ignores the flag and because all subsequentrequireuse a relative path all the files are loaded with the real path, making impossible setting breakpoints (that needs the absolute path of the file)- added a commit that references this issue
on Aug 15, 2016 - added a commit that references this issue
on Jul 27, 2026
Steps:
V:\ = \\CASTOR\\\CASTOR\scope\V:\scope\(or launch node from network disk:V:\scope\node.exe)require("ajv"); console.log(Object.keys(require.cache)[0])Output
node v6.1.0 (and previous):
V:\scope\node_modules\ajv\lib\ajv.jsnode v6.2.0 (and v6.2.1):
\\CASTOR\scope\node_modules\ajv\lib\ajv.jsprocess.cwd()in all versions:V:\\scope