Repository navigation
test_runner: todo/skip/expectFailure are truthy per docs, but implementation is otherwise #61815
Description
Activity
Based on my comment on #47537 (review), this seems like a bug - the empty string should be identical to
false.Reacted by Jacob SmithI can't think of a reason for them to not be truthy/falsy, like
skip: 'skip' in opts && !!opts.skipReacted by Jordan Harbandthe effective change will be that
'',null,NaNand the various flavors of0will no longer result in a todo/skip/expectFailure.My guess is only the first and maybe the second will likely break any existing clients and even that will be rare.
Reacted by Jordan Harband and Jacob SmithThis issue has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.still an issue
Version
v25.6.1
Subsystem
node:test
What steps will reproduce the bug?
Add the
todo,skiportestFailureoption to a test, setting it to an empty string. The result will be the same as if you set it totrueor a non-empty string.What is the expected behavior? Why is that the expected behavior?
Unsure whether the bug is in the code or in the API docs.
The code clearly does not treat these options as truthy:
node/lib/internal/test_runner/test.js
Lines 639 to 641 in 2de3482
But the docs specifically state they should be:
node/doc/api/test.md
Lines 1691 to 1696 in 2de3482
Additional information
Previous discussions:
expectFailuredevelopment: doc(proposal):expectFailurelabel and/or matcher test-runner#10 (comment) @JakobJingleheimer