Skip to content

The http2 server throws TypeError server.shouldUpgradeCallback is not a function #59922

Closed
#59924
Closed
The http2 server throws TypeError server.shouldUpgradeCallback is not a function#59922
#59924

Description

@ShenHongFei
ShenHongFei
opened on Sep 18, 2025

Version

origin/main branch

Platform

windows "$([Environment]::OSVersion.VersionString) $(('x86', 'x64')[[Environment]::Is64BitOperatingSystem])"

Subsystem

http

What steps will reproduce the bug?

import { createSecureServer } from 'http2'

let server = createSecureServer(...)

server.on('upgrade', () => { ... })

server.listen(443)

// Create a websocket connection to port 443

How often does it reproduce? Is there a required condition?

Must appear

What is the expected behavior? Why is that the expected behavior?

Websocket connection is normal

What do you see instead?

Image

Additional information

relates to: #59824

Can you (@pimterry) add relevant test cases for this PR? http server, http2 server and test websocket connection

Activity

  1. ShenHongFei
    changed the title [-]The http2 server does not handle the upgrade event properly.[/-] [+]The http2 server throws TypeError `server.shouldUpgradeCallback` is not a function[/+] on Sep 18, 2025

  2. pimterry commented on Sep 18, 2025

    @pimterry
    pimterry
    on Sep 18, 2025
    Member

    Thanks @ShenHongFei I'll look into this now. Can you share a complete example including the full HTTP/2 server options and the client connection code you're using? I'm a bit surprised that it's possible to hit this code path - in theory (https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/Protocol_upgrade_mechanism) upgrade shouldn't be possible in HTTP/2 at all.

  3. ShenHongFei commented on Sep 18, 2025

    @ShenHongFei
    ShenHongFei
    on Sep 18, 2025
    ContributorAuthor
    {
    ca: ...
    allowHTTP1: true
}

  4. pimterry commented on Sep 18, 2025

    @pimterry
    pimterry
    on Sep 18, 2025
    Member

    Should be fixed in #59924 @ShenHongFei

  5. ShenHongFei commented on Sep 18, 2025

    @ShenHongFei
    ShenHongFei
    on Sep 18, 2025
    ContributorAuthor

    @pimterry I just merged this PR locally and tried it. It works fine without any errors. Thank you very much.

    Do I need to close this issue? Or should I wait until your PR is merged?

  6. pimterry commented on Sep 18, 2025

    @pimterry
    pimterry
    on Sep 18, 2025
    Member

    Great, thanks for testing that @ShenHongFei! Let's leave this open until a fix is fully completed, that PR will close this issue automatically once it's merged.

  7. nodejs-github-bot
    closed this as completedin #59924on Sep 20, 2025

  8. cbn-falias commented on Oct 21, 2025

    @cbn-falias
    cbn-falias
    on Oct 21, 2025

    Hello,
    this also happened to me when upgrading from 22.17.0 to 22.21.0.
    Didn't check it in detail if it is the exact same error case but I noticed that the fix is tagged as dont-land-on-v22.x.
    Shouldn't this be also fixed in the LTS release?
    Thanks in advance!

  9. pimterry commented on Oct 21, 2025

    @pimterry
    pimterry
    on Oct 21, 2025
    Member

    Oooh, that's unfortunate, this may cause some breakage. Thanks for reporting this @cbn-falias.

    @aduh95 I think you did the 22.21.0 release, and it looks like you also tagged #59924 as not for v22. Unfortunately that change needed to go out with #59824, or it breaks at least one fairly common use case (websockets + HTTP/2).

    I'm not sure how the release & backporting workflows work, or why that was tagged not to be released. We will need to somehow do a patch release to include #59824 in v22 now though (or revert #59924, but I expect that's problematic). CC @nodejs/backporters.

  10. aduh95 commented on Oct 21, 2025

    @aduh95
    aduh95
    on Oct 21, 2025
    Contributor

    I'm not sure how the release & backporting workflows work

    It is documented in https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md, please open a manual backport PR so the change can be included in the next one

  11. pimterry commented on Oct 21, 2025

    @pimterry
    pimterry
    on Oct 21, 2025
    Member

    Ok, thanks, I'll backport it now.

  12. cirix commented on Oct 21, 2025

    @cirix
    cirix
    on Oct 21, 2025

    Hi all,
    I have just upgraded in my osx using brew and I am facing the same issue. Will a patch be issued?

    best regards

  13. pimterry commented on Oct 22, 2025

    @pimterry
    pimterry
    on Oct 22, 2025
    Member

    @cirix there's a fix open for this here: #60341. That needs to be reviewed & merged first, and then released in what will probably be v22.21.1.

    In the meantime, you can work around this by downgrading to v22.20 or older, or by upgrading to v24 - it's only v22.21.0 specifically that's broken.

  14. pimterry commented on Oct 22, 2025

    @pimterry
    pimterry
    on Oct 22, 2025
    Member

    There's a separate open issue for the v22 backport-specific issue at #60336, so lets track this there instead of reopening this original issue from the initial main branch changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions