Repository navigation
Soft deprecate punycode #5865
Description
Punycode has always been a pretty odd thing in Node IMO.
Not a lot of issues about it, people don't ask about it, no PRs touch it and no issues discuss it.
On the other hand it's around 500 lines of code - the implementation is slow and has a lot of fixes for things like IE8, or detecting the way exports are done from a module.
The docs aren't very up to date either. Also, this is definitely something that can be solved in userland faster anyway.
I think that we should soft-deprecate punycode as a core module and encourage people to install it from npm.
Activity
benjamingr commentedon Mar 23, 2016
I would label it with the punycode label but it doesn't look like there is one.
Also note that stability-index wise we're fine, it's stable but not locked
mscdex commentedon Mar 23, 2016
It's still used by the
urlmodule in core and possibly elsewhere in the ecosystem.If performance is a concern, why not fix those issues upstream and node can pull in the new version?
IMHO I don't see very strong arguments for removing it. You could view the lack of issues surrounding it as a testament to its stability. I also don't think it's something that really needs constant updating since the specs around it have been around for quite some time and the module is just complete.
jasnell commentedon Mar 23, 2016
Definitely -1 to removing it.
cjihrig commentedon Mar 23, 2016
Also -1 from me. I'm going to go ahead and close this for now.
benjamingr commentedon Mar 23, 2016
Good enough. I'll see if I can make some contributions on the implementation.
punycode: remove module detection